SabreTools/BinaryObjectScanner
1
0
Fork 0
mirror of https://github.com/SabreTools/BinaryObjectScanner.git synced 2026-05-19 13:33:13 +00:00
Code Issues 295 Packages Projects Releases 20 Wiki Activity

Don't reopen the stream unnecessarily

Browse Source
This commit is contained in:
Matt Nadareski
2025-09-06 10:58:46 -04:00
parent 168231cc94
commit 3a5e7004a3
2 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
BinaryObjectScanner/FileType/NewExecutable.cs
View File

@@ -46,14 +46,9 @@ namespace BinaryObjectScanner.FileType
} }
/// <inheritdoc/> /// <inheritdoc/>
/// <remarks>Uses the already-generated wrapper</remarks>
public bool Extract(string file, string outDir, bool includeDebug) public bool Extract(string file, string outDir, bool includeDebug)
{ => Extract(null, file, outDir, includeDebug);
if (!File.Exists(file))
return false;
using var fs = File.Open(file, FileMode.Open, FileAccess.Read, FileShare.ReadWrite);
return Extract(fs, file, outDir, includeDebug);
}
/// <inheritdoc/> /// <inheritdoc/>
public bool Extract(Stream? stream, string file, string outDir, bool includeDebug) public bool Extract(Stream? stream, string file, string outDir, bool includeDebug)

9
BinaryObjectScanner/FileType/PortableExecutable.cs
View File

@@ -46,14 +46,9 @@ namespace BinaryObjectScanner.FileType
} }
/// <inheritdoc/> /// <inheritdoc/>
/// <remarks>Uses the already-generated wrapper</remarks>
public bool Extract(string file, string outDir, bool includeDebug) public bool Extract(string file, string outDir, bool includeDebug)
{ => Extract(null, file, outDir, includeDebug);
if (!File.Exists(file))
return false;
using var fs = File.Open(file, FileMode.Open, FileAccess.Read, FileShare.ReadWrite);
return Extract(fs, file, outDir, includeDebug);
}
/// <inheritdoc/> /// <inheritdoc/>
public bool Extract(Stream? stream, string file, string outDir, bool includeDebug) public bool Extract(Stream? stream, string file, string outDir, bool includeDebug)