From ad449c2e33690b32a32aaf1156d7958f6418e660 Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Thu, 31 Jul 2025 09:14:21 -0400 Subject: [PATCH] Exception debugging should use Error stream --- BinaryObjectScanner/FileType/BZip2.cs | 2 +- BinaryObjectScanner/FileType/Executable.cs | 8 ++++---- BinaryObjectScanner/FileType/GZIP.cs | 2 +- BinaryObjectScanner/FileType/InstallShieldCAB.cs | 4 ++-- BinaryObjectScanner/FileType/LDSCRYPT.cs | 2 +- BinaryObjectScanner/FileType/MicrosoftCAB.cs | 12 ++++++------ BinaryObjectScanner/FileType/PKZIP.cs | 4 ++-- BinaryObjectScanner/FileType/PLJ.cs | 2 +- BinaryObjectScanner/FileType/RAR.cs | 6 +++--- BinaryObjectScanner/FileType/RealArcadeInstaller.cs | 2 +- BinaryObjectScanner/FileType/RealArcadeMezzanine.cs | 2 +- BinaryObjectScanner/FileType/SFFS.cs | 2 +- BinaryObjectScanner/FileType/SevenZip.cs | 6 +++--- BinaryObjectScanner/FileType/TapeArchive.cs | 4 ++-- BinaryObjectScanner/FileType/Textfile.cs | 2 +- BinaryObjectScanner/FileType/XZ.cs | 2 +- BinaryObjectScanner/Packer/CExe.cs | 2 +- BinaryObjectScanner/Packer/EmbeddedArchive.cs | 6 +++--- BinaryObjectScanner/Packer/EmbeddedExecutable.cs | 6 +++--- BinaryObjectScanner/Packer/WiseInstaller.cs | 4 ++-- ExtractionTool/Program.cs | 2 +- 21 files changed, 41 insertions(+), 41 deletions(-) diff --git a/BinaryObjectScanner/FileType/BZip2.cs b/BinaryObjectScanner/FileType/BZip2.cs index 25276784..fd5b98ae 100644 --- a/BinaryObjectScanner/FileType/BZip2.cs +++ b/BinaryObjectScanner/FileType/BZip2.cs @@ -53,7 +53,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } } diff --git a/BinaryObjectScanner/FileType/Executable.cs b/BinaryObjectScanner/FileType/Executable.cs index a6dcfb1b..be569a31 100644 --- a/BinaryObjectScanner/FileType/Executable.cs +++ b/BinaryObjectScanner/FileType/Executable.cs @@ -68,7 +68,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return protections; } @@ -166,7 +166,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return protections; } @@ -302,7 +302,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } // Prepare the returned protections @@ -312,7 +312,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return []; } } diff --git a/BinaryObjectScanner/FileType/GZIP.cs b/BinaryObjectScanner/FileType/GZIP.cs index 7569048a..8525a939 100644 --- a/BinaryObjectScanner/FileType/GZIP.cs +++ b/BinaryObjectScanner/FileType/GZIP.cs @@ -53,7 +53,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } } diff --git a/BinaryObjectScanner/FileType/InstallShieldCAB.cs b/BinaryObjectScanner/FileType/InstallShieldCAB.cs index 0dfbf906..aafad74f 100644 --- a/BinaryObjectScanner/FileType/InstallShieldCAB.cs +++ b/BinaryObjectScanner/FileType/InstallShieldCAB.cs @@ -88,7 +88,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } } @@ -96,7 +96,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } } diff --git a/BinaryObjectScanner/FileType/LDSCRYPT.cs b/BinaryObjectScanner/FileType/LDSCRYPT.cs index f778bc4c..a66c7bc6 100644 --- a/BinaryObjectScanner/FileType/LDSCRYPT.cs +++ b/BinaryObjectScanner/FileType/LDSCRYPT.cs @@ -33,7 +33,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } return null; diff --git a/BinaryObjectScanner/FileType/MicrosoftCAB.cs b/BinaryObjectScanner/FileType/MicrosoftCAB.cs index ac751e21..b50e6a80 100644 --- a/BinaryObjectScanner/FileType/MicrosoftCAB.cs +++ b/BinaryObjectScanner/FileType/MicrosoftCAB.cs @@ -56,7 +56,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } @@ -89,7 +89,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } } @@ -97,7 +97,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } #endif @@ -169,7 +169,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } } @@ -237,7 +237,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } } @@ -349,7 +349,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return []; } } diff --git a/BinaryObjectScanner/FileType/PKZIP.cs b/BinaryObjectScanner/FileType/PKZIP.cs index 1b418d9d..7367c40b 100644 --- a/BinaryObjectScanner/FileType/PKZIP.cs +++ b/BinaryObjectScanner/FileType/PKZIP.cs @@ -81,7 +81,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } } @@ -89,7 +89,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } #else diff --git a/BinaryObjectScanner/FileType/PLJ.cs b/BinaryObjectScanner/FileType/PLJ.cs index b159f39b..ea793c71 100644 --- a/BinaryObjectScanner/FileType/PLJ.cs +++ b/BinaryObjectScanner/FileType/PLJ.cs @@ -33,7 +33,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } return null; diff --git a/BinaryObjectScanner/FileType/RAR.cs b/BinaryObjectScanner/FileType/RAR.cs index ea44a146..f5a75ddd 100644 --- a/BinaryObjectScanner/FileType/RAR.cs +++ b/BinaryObjectScanner/FileType/RAR.cs @@ -60,7 +60,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } #else @@ -109,7 +109,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } } return true; @@ -135,7 +135,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } return true; diff --git a/BinaryObjectScanner/FileType/RealArcadeInstaller.cs b/BinaryObjectScanner/FileType/RealArcadeInstaller.cs index b6bd79aa..31422cc1 100644 --- a/BinaryObjectScanner/FileType/RealArcadeInstaller.cs +++ b/BinaryObjectScanner/FileType/RealArcadeInstaller.cs @@ -37,7 +37,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } return null; diff --git a/BinaryObjectScanner/FileType/RealArcadeMezzanine.cs b/BinaryObjectScanner/FileType/RealArcadeMezzanine.cs index 3cabc04e..5603269f 100644 --- a/BinaryObjectScanner/FileType/RealArcadeMezzanine.cs +++ b/BinaryObjectScanner/FileType/RealArcadeMezzanine.cs @@ -37,7 +37,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } return null; diff --git a/BinaryObjectScanner/FileType/SFFS.cs b/BinaryObjectScanner/FileType/SFFS.cs index 6a41f9cc..d8e2b565 100644 --- a/BinaryObjectScanner/FileType/SFFS.cs +++ b/BinaryObjectScanner/FileType/SFFS.cs @@ -34,7 +34,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } return null; diff --git a/BinaryObjectScanner/FileType/SevenZip.cs b/BinaryObjectScanner/FileType/SevenZip.cs index 03c18677..7dbd5931 100644 --- a/BinaryObjectScanner/FileType/SevenZip.cs +++ b/BinaryObjectScanner/FileType/SevenZip.cs @@ -58,7 +58,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } #else @@ -106,7 +106,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } } return true; @@ -132,7 +132,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } return true; diff --git a/BinaryObjectScanner/FileType/TapeArchive.cs b/BinaryObjectScanner/FileType/TapeArchive.cs index 73768f99..5889845a 100644 --- a/BinaryObjectScanner/FileType/TapeArchive.cs +++ b/BinaryObjectScanner/FileType/TapeArchive.cs @@ -71,7 +71,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } } @@ -79,7 +79,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } #else diff --git a/BinaryObjectScanner/FileType/Textfile.cs b/BinaryObjectScanner/FileType/Textfile.cs index 03b7af03..9ba288c6 100644 --- a/BinaryObjectScanner/FileType/Textfile.cs +++ b/BinaryObjectScanner/FileType/Textfile.cs @@ -178,7 +178,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } // Only return if there are protections found diff --git a/BinaryObjectScanner/FileType/XZ.cs b/BinaryObjectScanner/FileType/XZ.cs index fcfa6eed..d70eada4 100644 --- a/BinaryObjectScanner/FileType/XZ.cs +++ b/BinaryObjectScanner/FileType/XZ.cs @@ -56,7 +56,7 @@ namespace BinaryObjectScanner.FileType } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } #else diff --git a/BinaryObjectScanner/Packer/CExe.cs b/BinaryObjectScanner/Packer/CExe.cs index 06aa2da2..e8c960b2 100644 --- a/BinaryObjectScanner/Packer/CExe.cs +++ b/BinaryObjectScanner/Packer/CExe.cs @@ -141,7 +141,7 @@ namespace BinaryObjectScanner.Packer } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } } diff --git a/BinaryObjectScanner/Packer/EmbeddedArchive.cs b/BinaryObjectScanner/Packer/EmbeddedArchive.cs index 29164899..0007bd07 100644 --- a/BinaryObjectScanner/Packer/EmbeddedArchive.cs +++ b/BinaryObjectScanner/Packer/EmbeddedArchive.cs @@ -110,7 +110,7 @@ namespace BinaryObjectScanner.Packer } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } } @@ -165,7 +165,7 @@ namespace BinaryObjectScanner.Packer } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } } @@ -173,7 +173,7 @@ namespace BinaryObjectScanner.Packer } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } } diff --git a/BinaryObjectScanner/Packer/EmbeddedExecutable.cs b/BinaryObjectScanner/Packer/EmbeddedExecutable.cs index 79363033..c3026346 100644 --- a/BinaryObjectScanner/Packer/EmbeddedExecutable.cs +++ b/BinaryObjectScanner/Packer/EmbeddedExecutable.cs @@ -78,7 +78,7 @@ namespace BinaryObjectScanner.Packer } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } } @@ -118,7 +118,7 @@ namespace BinaryObjectScanner.Packer } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); } } @@ -126,7 +126,7 @@ namespace BinaryObjectScanner.Packer } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } } diff --git a/BinaryObjectScanner/Packer/WiseInstaller.cs b/BinaryObjectScanner/Packer/WiseInstaller.cs index dea306f3..d3fbf2c8 100644 --- a/BinaryObjectScanner/Packer/WiseInstaller.cs +++ b/BinaryObjectScanner/Packer/WiseInstaller.cs @@ -77,7 +77,7 @@ namespace BinaryObjectScanner.Packer } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } } @@ -92,7 +92,7 @@ namespace BinaryObjectScanner.Packer } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return false; } } diff --git a/ExtractionTool/Program.cs b/ExtractionTool/Program.cs index 4a09cd8a..cb2ff741 100644 --- a/ExtractionTool/Program.cs +++ b/ExtractionTool/Program.cs @@ -84,7 +84,7 @@ namespace ExtractionTool } catch (Exception ex) { - if (includeDebug) Console.WriteLine(ex); + if (includeDebug) Console.Error.WriteLine(ex); return; }