Downstream potential fixes for testing

This commit is contained in:
Matt Nadareski
2025-09-03 08:35:19 -04:00
parent d2ed0a822a
commit c70f0d72d2
5 changed files with 203 additions and 14 deletions

View File

@@ -62,9 +62,9 @@ namespace BinaryObjectScanner.Protection
}
// Get the overlay data, if it exists
if (pex.OverlayStrings != null)
if (FileType.Executable.GetOverlayStrings(pex) != null)
{
if (pex.OverlayStrings.Exists(s => s.Contains("TMSAMVOH")))
if (FileType.Executable.GetOverlayStrings(pex)!.Exists(s => s.Contains("TMSAMVOH")))
return "ActiveMARK";
}

View File

@@ -75,10 +75,10 @@ namespace BinaryObjectScanner.Protection
}
// Get the overlay data, if it exists
if (pex.OverlayStrings != null)
if (FileType.Executable.GetOverlayStrings(pex) != null)
{
// Found in Redump entry 84122.
if (pex.OverlayStrings.Exists(s => s.Contains("SETTEC0000")))
if (FileType.Executable.GetOverlayStrings(pex)!.Exists(s => s.Contains("SETTEC0000")))
return "Alpha-ROM";
}

View File

@@ -66,7 +66,7 @@ namespace BinaryObjectScanner.Protection
if (sections == null)
return null;
if (pex.OverlayStrings != null)
if (FileType.Executable.GetOverlayStrings(pex) != null)
{
// Checks if main executable contains reference to optgraph.dll.
// This might be better removed later, as Redump ID 82475 is a false positive, and also doesn't actually
@@ -76,7 +76,7 @@ namespace BinaryObjectScanner.Protection
// TODO: This might need to check every single section. Unsure until more samples are acquired.
// TODO: TKKG also has an NE 3.1x executable with a reference. This can be added later.
// Samples: Redump ID 108150
if (pex.OverlayStrings.Exists(s => s.Contains("optgraph.dll")))
if (FileType.Executable.GetOverlayStrings(pex)!.Exists(s => s.Contains("optgraph.dll")))
return "copy-X [Check disc for physical ring]";
}

View File

@@ -64,9 +64,9 @@ namespace BinaryObjectScanner.Protection
return $"SecuROM SLL Protected (for SecuROM v8.x)";
// Search after the last section
if (pex.OverlayStrings != null)
if (FileType.Executable.GetOverlayStrings(pex) != null)
{
if (pex.OverlayStrings.Exists(s => s == "AddD"))
if (FileType.Executable.GetOverlayStrings(pex)!.Exists(s => s == "AddD"))
return $"SecuROM {GetV4Version(pex)}";
}