Refactor Setup Factory detection (#115)

* Refactor Setup Factory detection

* Address Setup Factory PR comments

* Fix whitespace
This commit is contained in:
SilasLaspada
2022-04-01 10:58:02 -06:00
committed by GitHub
parent 35acb77bf7
commit edc4cc1706
2 changed files with 24 additions and 6 deletions

View File

@@ -237,9 +237,9 @@ namespace BurnOutSharp.Tools
if (!string.IsNullOrWhiteSpace(version))
return version.Replace(", ", ".");
version = GetResourceString(pex, "ProductVersion");
version = GetProductVersion(pex);
if (!string.IsNullOrWhiteSpace(version))
return version.Replace(", ", ".");
return version;
return null;
}
@@ -366,6 +366,13 @@ namespace BurnOutSharp.Tools
/// <returns>Product name string, null on error</returns>
public static string GetProductName(PortableExecutable pex) => GetResourceString(pex, "ProductName");
/// <summary>
/// Get the product name as reported by the filesystem
/// </summary>
/// <param name="pex">PortableExecutable representing the file contents</param>
/// <returns>Product version string, null on error</returns>
public static string GetProductVersion(PortableExecutable pex) => GetResourceString(pex, "ProductVersion")?.Replace(", ", ".");
/// <summary>
/// Find resource data in a ResourceSection, if possible
/// </summary>