[PR #4] [MERGED] Fix Memory Issues #213

Open
opened 2026-01-29 21:07:16 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/SabreTools/BinaryObjectScanner/pull/4
Author: @mnadareski
Created: 10/24/2019
Status: Merged
Merged: 10/24/2019
Merged by: @mnadareski

Base: masterHead: reorg


📝 Commits (4)

  • dd99c83 Fix a couple of protection scans (possible mem issues)
  • ecc5c96 Don't open the file contents on path scan for antimodchip
  • cbf9aab IS-CAB intermediate filtering to reduce scan times
  • 7d662bd Update NuGet version

📊 Changes

4 files changed (+49 additions, -41 deletions)

View changed files

📝 BurnOutSharp/BurnOutSharp.nuspec (+1 -1)
📝 BurnOutSharp/ProtectionFind.cs (+36 -20)
📝 BurnOutSharp/ProtectionType/CactusDataShield.cs (+2 -2)
📝 BurnOutSharp/ProtectionType/PSXAntiModchip.cs (+10 -18)

📄 Description

After the recent reorganization of the code, there ended up being some parts that were less well-formatted than others, which lead to some issues while being used in DICUI. This included out of memory issues on DVD-9 discs. The changes here should reduce the amount of memory that is being used in any given protection scan as well as reduce the amount of time for InstallShield CAB files since all of them scanned every CAB every time.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/BinaryObjectScanner/pull/4 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 10/24/2019 **Status:** ✅ Merged **Merged:** 10/24/2019 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `reorg` --- ### 📝 Commits (4) - [`dd99c83`](https://github.com/SabreTools/BinaryObjectScanner/commit/dd99c83848102d744d447c65c1dd377a013e8d86) Fix a couple of protection scans (possible mem issues) - [`ecc5c96`](https://github.com/SabreTools/BinaryObjectScanner/commit/ecc5c968f12e7f6cdf86f2903a0425db44d4012f) Don't open the file contents on path scan for antimodchip - [`cbf9aab`](https://github.com/SabreTools/BinaryObjectScanner/commit/cbf9aab435f179034b54e1d9f901132595418b09) IS-CAB intermediate filtering to reduce scan times - [`7d662bd`](https://github.com/SabreTools/BinaryObjectScanner/commit/7d662bd61e1dc27bcab5ed5ae9fdc410d7a8822c) Update NuGet version ### 📊 Changes **4 files changed** (+49 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `BurnOutSharp/BurnOutSharp.nuspec` (+1 -1) 📝 `BurnOutSharp/ProtectionFind.cs` (+36 -20) 📝 `BurnOutSharp/ProtectionType/CactusDataShield.cs` (+2 -2) 📝 `BurnOutSharp/ProtectionType/PSXAntiModchip.cs` (+10 -18) </details> ### 📄 Description After the recent reorganization of the code, there ended up being some parts that were less well-formatted than others, which lead to some issues while being used in DICUI. This included out of memory issues on DVD-9 discs. The changes here should reduce the amount of memory that is being used in any given protection scan as well as reduce the amount of time for InstallShield CAB files since all of them scanned every CAB every time. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 21:07:16 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/BinaryObjectScanner#213