mirror of
https://github.com/SabreTools/BinaryObjectScanner.git
synced 2026-02-04 05:35:49 +00:00
[PR #4] [MERGED] Fix Memory Issues #213
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/SabreTools/BinaryObjectScanner/pull/4
Author: @mnadareski
Created: 10/24/2019
Status: ✅ Merged
Merged: 10/24/2019
Merged by: @mnadareski
Base:
master← Head:reorg📝 Commits (4)
dd99c83Fix a couple of protection scans (possible mem issues)ecc5c96Don't open the file contents on path scan for antimodchipcbf9aabIS-CAB intermediate filtering to reduce scan times7d662bdUpdate NuGet version📊 Changes
4 files changed (+49 additions, -41 deletions)
View changed files
📝
BurnOutSharp/BurnOutSharp.nuspec(+1 -1)📝
BurnOutSharp/ProtectionFind.cs(+36 -20)📝
BurnOutSharp/ProtectionType/CactusDataShield.cs(+2 -2)📝
BurnOutSharp/ProtectionType/PSXAntiModchip.cs(+10 -18)📄 Description
After the recent reorganization of the code, there ended up being some parts that were less well-formatted than others, which lead to some issues while being used in DICUI. This included out of memory issues on DVD-9 discs. The changes here should reduce the amount of memory that is being used in any given protection scan as well as reduce the amount of time for InstallShield CAB files since all of them scanned every CAB every time.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.