SabreTools/BinaryObjectScanner
1
0
Fork 0
mirror of https://github.com/SabreTools/BinaryObjectScanner.git synced 2026-02-04 05:35:49 +00:00
Code Issues 295 Packages Projects Releases 20 Wiki Activity

[PR #5] [MERGED] Pathing issues #214

New Issue
Closed
opened 2026-01-29 21:07:16 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 21:07:16 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/BinaryObjectScanner/pull/5
Author: @mnadareski
Created: 10/26/2019
Status: ✅ Merged
Merged: 10/26/2019
Merged by: @mnadareski

Base: master ← Head: macattack

📝 Commits (1)

  • 7f7c5c8 Missing or moved files shouldn't cause an issue

📊 Changes

14 files changed (+36 additions, -29 deletions)

View changed files

📝 BurnOutSharp/BurnOutSharp.nuspec (+1 -1)
📝 BurnOutSharp/EVORE.cs (+5 -5)
📝 BurnOutSharp/ProtectionType/CDCops.cs (+1 -1)
📝 BurnOutSharp/ProtectionType/DVDCops.cs (+1 -1)
📝 BurnOutSharp/ProtectionType/InnoSetup.cs (+1 -1)
📝 BurnOutSharp/ProtectionType/JoWooDXProt.cs (+1 -1)
📝 BurnOutSharp/ProtectionType/ProtectDisc.cs (+2 -2)
📝 BurnOutSharp/ProtectionType/SafeDisc.cs (+14 -7)
📝 BurnOutSharp/ProtectionType/SecuROM.cs (+3 -3)
📝 BurnOutSharp/ProtectionType/SolidShield.cs (+1 -1)
📝 BurnOutSharp/ProtectionType/Sysiphus.cs (+1 -1)
📝 BurnOutSharp/ProtectionType/Tages.cs (+1 -1)
📝 BurnOutSharp/ProtectionType/VOBProtectCDDVD.cs (+3 -3)
📝 BurnOutSharp/Utilities.cs (+1 -1)

📄 Description

This PR addresses 3 distinct things having to do with paths:

  • It enables preliminary path-only scanning of SafeDisc for Macintosh
  • It fixes path scanning for all other SafeDisc versions (on directory scan)
  • It makes sure that all places that only checked for null files also check for file existence first

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/BinaryObjectScanner/pull/5 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 10/26/2019 **Status:** ✅ Merged **Merged:** 10/26/2019 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `macattack` --- ### 📝 Commits (1) - [`7f7c5c8`](https://github.com/SabreTools/BinaryObjectScanner/commit/7f7c5c84d4a07d49546cd3a7d5337f206141af98) Missing or moved files shouldn't cause an issue ### 📊 Changes **14 files changed** (+36 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `BurnOutSharp/BurnOutSharp.nuspec` (+1 -1) 📝 `BurnOutSharp/EVORE.cs` (+5 -5) 📝 `BurnOutSharp/ProtectionType/CDCops.cs` (+1 -1) 📝 `BurnOutSharp/ProtectionType/DVDCops.cs` (+1 -1) 📝 `BurnOutSharp/ProtectionType/InnoSetup.cs` (+1 -1) 📝 `BurnOutSharp/ProtectionType/JoWooDXProt.cs` (+1 -1) 📝 `BurnOutSharp/ProtectionType/ProtectDisc.cs` (+2 -2) 📝 `BurnOutSharp/ProtectionType/SafeDisc.cs` (+14 -7) 📝 `BurnOutSharp/ProtectionType/SecuROM.cs` (+3 -3) 📝 `BurnOutSharp/ProtectionType/SolidShield.cs` (+1 -1) 📝 `BurnOutSharp/ProtectionType/Sysiphus.cs` (+1 -1) 📝 `BurnOutSharp/ProtectionType/Tages.cs` (+1 -1) 📝 `BurnOutSharp/ProtectionType/VOBProtectCDDVD.cs` (+3 -3) 📝 `BurnOutSharp/Utilities.cs` (+1 -1) </details> ### 📄 Description This PR addresses 3 distinct things having to do with paths: - It enables preliminary path-only scanning of SafeDisc for Macintosh - It fixes path scanning for all other SafeDisc versions (on directory scan) - It makes sure that all places that only checked for `null` files also check for file existence first --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 21:07:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/BinaryObjectScanner#214
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?