[PR #37] [MERGED] Improve Inno Setup detection #242

New Issue

Open

opened 2026-01-29 21:07:22 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:07:22 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/BinaryObjectScanner/pull/37
Author: @TheRogueArchivist
Created: 5/29/2021
Status: ✅ Merged
Merged: 6/5/2021
Merged by: @mnadareski

Base: master ← Head: InnoSetup

---

📝 Commits (6)

• eb1fc3c Improve Inno Setup detection
• 51c2925 Split "GetVersion"
• 040f038 Remove unneeded check
• 9f06798 Make version detection more robust
• d43deb9 Add Unicode version detection
• 5058e6b Address review comments

📊 Changes

1 file changed (+38 additions, -27 deletions)

View changed files

📝 BurnOutSharp/PackerType/InnoSetup.cs (+38 -27)

📄 Description

Add generic version detection for at least some versions (tested with version 5.1.2)

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/BinaryObjectScanner/pull/37 **Author:** [@TheRogueArchivist](https://github.com/TheRogueArchivist) **Created:** 5/29/2021 **Status:** ✅ Merged **Merged:** 6/5/2021 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `InnoSetup` --- ### 📝 Commits (6) - [`eb1fc3c`](https://github.com/SabreTools/BinaryObjectScanner/commit/eb1fc3c4ddd2da9de9247b9c985b861cb187384e) Improve Inno Setup detection - [`51c2925`](https://github.com/SabreTools/BinaryObjectScanner/commit/51c2925b2ad7478b0425cc1c6a61673fc1052cba) Split "GetVersion" - [`040f038`](https://github.com/SabreTools/BinaryObjectScanner/commit/040f0382107c18ac18df4740534417e5606f5cb3) Remove unneeded check - [`9f06798`](https://github.com/SabreTools/BinaryObjectScanner/commit/9f06798daa1e8b5f6576ffbda974068173922afd) Make version detection more robust - [`d43deb9`](https://github.com/SabreTools/BinaryObjectScanner/commit/d43deb9c8fb2a49d1a7ffaca75ae0c8c6dae3912) Add Unicode version detection - [`5058e6b`](https://github.com/SabreTools/BinaryObjectScanner/commit/5058e6b64bdfb6c1f7d365e241358fc30c47723a) Address review comments ### 📊 Changes **1 file changed** (+38 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `BurnOutSharp/PackerType/InnoSetup.cs` (+38 -27) </details> ### 📄 Description Add generic version detection for at least some versions (tested with version 5.1.2) --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:07:22 +00:00

claunia referenced this issue 2026-01-29 21:08:25 +00:00

[PR #301] [MERGED] Add check for StarForce driver removal tool #468

claunia referenced this issue 2026-01-29 21:08:26 +00:00

[PR #301] Add check for StarForce driver removal tool #473

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.5.0

3.4.6

3.4.5

3.4.4

3.4.3

3.4.2

3.4.1

3.4.0

3.3.4

3.3.3

3.3.2

3.3.1

3.3.0

3.2.3

3.2.2

3.2.1

3.2.0

3.1.16

3.1.15

3.1.14

3.1.13

3.1.12

3.1.11

3.1.10

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

3.1.1

3.1.0

3.0.2

3.0.1

3.0.0

2.9.0

2.8.0

2.7.0

2.6.0

2.5.0

2.3.4

2.3.3

2.3.2

2.3.1

2.3.0

2.1.0

2.0.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.1

1.5.0

1.4.1

1.4.0

1.03.9.1

1.03.9

1.03.8.2

1.03.8.1

1.03.8.0

1.03.7.1

1.03.5

1.03.7

1.03.6

Labels

Clear labels

bug

enhancement

help wanted

pull-request

Mirrored from GitHub Pull Request

question

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/BinaryObjectScanner#242