[PR #115] [MERGED] Refactor Setup Factory detection #272

New Issue

Open

opened 2026-01-29 21:07:33 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:07:33 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/BinaryObjectScanner/pull/115
Author: @TheRogueArchivist
Created: 4/1/2022
Status: ✅ Merged
Merged: 4/1/2022
Merged by: @mnadareski

Base: master ← Head: Setup-Factory-Refactor

---

📝 Commits (3)

• 1d0ae5c Refactor Setup Factory detection
• e1c603d Address Setup Factory PR comments
• e688eee Fix whitespace

📊 Changes

2 files changed (+24 additions, -6 deletions)

View changed files

📝 BurnOutSharp/PackerType/SetupFactory.cs (+15 -4)
📝 BurnOutSharp/Tools/Utilities.cs (+9 -2)

📄 Description

Fix a broken Setup Factory check, add a new check that works for older versions, and add a new method to grab the product version, which is needed to accurately grab some Setup Factory versions.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/BinaryObjectScanner/pull/115 **Author:** [@TheRogueArchivist](https://github.com/TheRogueArchivist) **Created:** 4/1/2022 **Status:** ✅ Merged **Merged:** 4/1/2022 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `Setup-Factory-Refactor` --- ### 📝 Commits (3) - [`1d0ae5c`](https://github.com/SabreTools/BinaryObjectScanner/commit/1d0ae5c94c039fd356b345e0b319facb47aac67c) Refactor Setup Factory detection - [`e1c603d`](https://github.com/SabreTools/BinaryObjectScanner/commit/e1c603d85b6ab42da870d934e3d792ce63a1135b) Address Setup Factory PR comments - [`e688eee`](https://github.com/SabreTools/BinaryObjectScanner/commit/e688eeecfcf62341f23c9e28a53377ab2cdf69d6) Fix whitespace ### 📊 Changes **2 files changed** (+24 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `BurnOutSharp/PackerType/SetupFactory.cs` (+15 -4) 📝 `BurnOutSharp/Tools/Utilities.cs` (+9 -2) </details> ### 📄 Description Fix a broken Setup Factory check, add a new check that works for older versions, and add a new method to grab the product version, which is needed to accurately grab some Setup Factory versions. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:07:33 +00:00

claunia referenced this issue 2026-01-29 21:08:16 +00:00

[PR #272] [MERGED] Add small note about ProtectDISC using CSS #435

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.5.0

3.4.6

3.4.5

3.4.4

3.4.3

3.4.2

3.4.1

3.4.0

3.3.4

3.3.3

3.3.2

3.3.1

3.3.0

3.2.3

3.2.2

3.2.1

3.2.0

3.1.16

3.1.15

3.1.14

3.1.13

3.1.12

3.1.11

3.1.10

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

3.1.1

3.1.0

3.0.2

3.0.1

3.0.0

2.9.0

2.8.0

2.7.0

2.6.0

2.5.0

2.3.4

2.3.3

2.3.2

2.3.1

2.3.0

2.1.0

2.0.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.1

1.5.0

1.4.1

1.4.0

1.03.9.1

1.03.9

1.03.8.2

1.03.8.1

1.03.8.0

1.03.7.1

1.03.5

1.03.7

1.03.6

Labels

Clear labels

bug

enhancement

help wanted

pull-request

Mirrored from GitHub Pull Request

question

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/BinaryObjectScanner#272