[PR #284] [MERGED] Remove GetVersionFromSHA1Hash from SafeDisc #451

New Issue

Closed

opened 2026-01-29 21:08:21 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:08:21 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/BinaryObjectScanner/pull/284
Author: @TheRogueArchivist
Created: 2/23/2024
Status: ✅ Merged
Merged: 2/23/2024
Merged by: @mnadareski

Base: master ← Head: safedisc-sha1-cleanup

---

📝 Commits (1)

• e46114d Remove GetVersionFromSHA1Hash from SafeDisc

📊 Changes

2 files changed (+33 additions, -35 deletions)

View changed files

📝 BinaryObjectScanner/Protection/Macrovision.SafeDisc.cs (+15 -33)
📝 BinaryObjectScanner/Protection/Macrovision.cs (+18 -2)

📄 Description

GetVersionFromSHA1Hash has only had essentially useless hashes for a while now, since all the remaining one is are for files that appear to change hash between games. Not only that, but nothing has used it, due it not being useful. I've removed it entirely, added the information that was in it to comments for the appropriate file checks, and also cleaned up a few miscellaneous comment issues that I noticed.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/BinaryObjectScanner/pull/284 **Author:** [@TheRogueArchivist](https://github.com/TheRogueArchivist) **Created:** 2/23/2024 **Status:** ✅ Merged **Merged:** 2/23/2024 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `safedisc-sha1-cleanup` --- ### 📝 Commits (1) - [`e46114d`](https://github.com/SabreTools/BinaryObjectScanner/commit/e46114decfb68ec16874920228a98c7e1da33f08) Remove GetVersionFromSHA1Hash from SafeDisc ### 📊 Changes **2 files changed** (+33 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `BinaryObjectScanner/Protection/Macrovision.SafeDisc.cs` (+15 -33) 📝 `BinaryObjectScanner/Protection/Macrovision.cs` (+18 -2) </details> ### 📄 Description `GetVersionFromSHA1Hash` has only had essentially useless hashes for a while now, since all the remaining one is are for files that appear to change hash between games. Not only that, but nothing has used it, due it not being useful. I've removed it entirely, added the information that was in it to comments for the appropriate file checks, and also cleaned up a few miscellaneous comment issues that I noticed. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:08:21 +00:00

claunia closed this issue 2026-01-29 21:08:21 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.5.0

3.4.6

3.4.5

3.4.4

3.4.3

3.4.2

3.4.1

3.4.0

3.3.4

3.3.3

3.3.2

3.3.1

3.3.0

3.2.3

3.2.2

3.2.1

3.2.0

3.1.16

3.1.15

3.1.14

3.1.13

3.1.12

3.1.11

3.1.10

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

3.1.1

3.1.0

3.0.2

3.0.1

3.0.0

2.9.0

2.8.0

2.7.0

2.6.0

2.5.0

2.3.4

2.3.3

2.3.2

2.3.1

2.3.0

2.1.0

2.0.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.1

1.5.0

1.4.1

1.4.0

1.03.9.1

1.03.9

1.03.8.2

1.03.8.1

1.03.8.0

1.03.7.1

1.03.5

1.03.7

1.03.6

Labels

Clear labels

bug

enhancement

help wanted

pull-request

Mirrored from GitHub Pull Request

question

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/BinaryObjectScanner#451