SabreTools/BinaryObjectScanner
1
0
Fork 0
mirror of https://github.com/SabreTools/BinaryObjectScanner.git synced 2026-02-03 21:29:23 +00:00
Code Issues 295 Packages Projects Releases 20 Wiki Activity

[PR #296] [MERGED] Fix a crash when a sharing violation occurs during --info #460

New Issue
Open
opened 2026-01-29 21:08:23 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 21:08:23 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/BinaryObjectScanner/pull/296
Author: @CookiePLMonster
Created: 4/3/2024
Status: ✅ Merged
Merged: 4/3/2024
Merged by: @mnadareski

Base: master ← Head: fix-info-crash

📝 Commits (1)

  • 09fba1d Fix a crash when a sharing violation occurs during --info

📊 Changes

1 file changed (+51 additions, -43 deletions)

View changed files

📝 Test/Printer.cs (+51 -43)

📄 Description

I was running a scan with --info on a directory where an open IDA database resided, and BOS crashed on a sharing violation when attempting to open those files. I modified PrintFileInfo to deal with failure the same way GetInternalProtections does.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/BinaryObjectScanner/pull/296 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 4/3/2024 **Status:** ✅ Merged **Merged:** 4/3/2024 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `fix-info-crash` --- ### 📝 Commits (1) - [`09fba1d`](https://github.com/SabreTools/BinaryObjectScanner/commit/09fba1d91e5fe573262fd12c90fc942aa91566ff) Fix a crash when a sharing violation occurs during --info ### 📊 Changes **1 file changed** (+51 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `Test/Printer.cs` (+51 -43) </details> ### 📄 Description I was running a scan with `--info` on a directory where an open IDA database resided, and BOS crashed on a sharing violation when attempting to open those files. I modified `PrintFileInfo` to deal with failure the same way `GetInternalProtections` does. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 21:08:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/BinaryObjectScanner#460
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?