[PR #297] [MERGED] Update SecuROM v7 detection to correctly handle a partly stripped header #462

New Issue

Open

opened 2026-01-29 21:08:23 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:08:23 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/BinaryObjectScanner/pull/297
Author: @CookiePLMonster
Created: 4/4/2024
Status: ✅ Merged
Merged: 4/4/2024
Merged by: @mnadareski

Base: master ← Head: securom-v7-fix

---

📝 Commits (1)

• 93d9eaf Update SecuROM v7 detection to correctly handle a partly stripped header

📊 Changes

1 file changed (+26 additions, -17 deletions)

View changed files

📝 BinaryObjectScanner/Protection/SecuROM.cs (+26 -17)

📄 Description

Executable mentioned in https://github.com/SabreTools/BinaryObjectScanner/issues/142 had a .securom section, but the extended MS-DOS header has been stripped. Therefore, BOS threw an exception when analyzing that file inside GetV7Version.

Added a range check to the function and treated its failure as "remnants" of SecuROM - because we know SecuROM was there, but we don't know what exact version.

Fixes #142.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/BinaryObjectScanner/pull/297 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 4/4/2024 **Status:** ✅ Merged **Merged:** 4/4/2024 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `securom-v7-fix` --- ### 📝 Commits (1) - [`93d9eaf`](https://github.com/SabreTools/BinaryObjectScanner/commit/93d9eaf7a716ce73a0d7b3b5724496d00092dfad) Update SecuROM v7 detection to correctly handle a partly stripped header ### 📊 Changes **1 file changed** (+26 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `BinaryObjectScanner/Protection/SecuROM.cs` (+26 -17) </details> ### 📄 Description Executable mentioned in https://github.com/SabreTools/BinaryObjectScanner/issues/142 had a `.securom` section, but the extended MS-DOS header has been stripped. Therefore, BOS threw an exception when analyzing that file inside `GetV7Version`. Added a range check to the function and treated its failure as "remnants" of SecuROM - because we know SecuROM was there, but we don't know what exact version. Fixes #142. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:08:23 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.5.0

3.4.6

3.4.5

3.4.4

3.4.3

3.4.2

3.4.1

3.4.0

3.3.4

3.3.3

3.3.2

3.3.1

3.3.0

3.2.3

3.2.2

3.2.1

3.2.0

3.1.16

3.1.15

3.1.14

3.1.13

3.1.12

3.1.11

3.1.10

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

3.1.1

3.1.0

3.0.2

3.0.1

3.0.0

2.9.0

2.8.0

2.7.0

2.6.0

2.5.0

2.3.4

2.3.3

2.3.2

2.3.1

2.3.0

2.1.0

2.0.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.1

1.5.0

1.4.1

1.4.0

1.03.9.1

1.03.9

1.03.8.2

1.03.8.1

1.03.8.0

1.03.7.1

1.03.5

1.03.7

1.03.6

Labels

Clear labels

bug

enhancement

help wanted

pull-request

Mirrored from GitHub Pull Request

question

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/BinaryObjectScanner#462