mirror of
https://github.com/SabreTools/BinaryObjectScanner.git
synced 2026-02-04 05:35:49 +00:00
[PR #321] [MERGED] [WIP] Add 7-Zip SFX extraction #487
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/SabreTools/BinaryObjectScanner/pull/321
Author: @TheRogueArchivist
Created: 9/25/2024
Status: ✅ Merged
Merged: 9/26/2024
Merged by: @mnadareski
Base:
master← Head:7zip-SFX📝 Commits (6)
9d20820Add 7-Zip SFX extraction1a3d933Merge branch 'SabreTools:master' into 7zip-SFX055bf61Clean up 7z SFX extraction method116f0eeRemove unneeded importe66f7f3Use file instead of stream for 7z SFXe1283d6Update 7z SFX to be more consistent with other packers📊 Changes
1 file changed (+57 additions, -1 deletions)
View changed files
📝
BinaryObjectScanner/Packer/SevenZipSFX.cs(+57 -1)📄 Description
Newest SharpCompress added support for extracting 7-Zip SFX files, so we can add support for them here too.
Relies on #320, or SharpCompress being updated to 0.38.0 otherwise. There appears to be a bug present where files in a folder inside of 7z archives aren't extracted, but this occurs with normal 7z archives in latest release as well and will be reported separately. So, this has been marked as "[WIP]" in-case changes need to be made to the extraction code in SFX as well. Alternatively, this can be merged and then the bug can be dealt with at a later time.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.