[PR #368] [MERGED] Improve detection for cd/dvd-cops version string #521

New Issue

Closed

opened 2026-01-29 21:09:53 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:09:53 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/BinaryObjectScanner/pull/368
Author: @HeroponRikiBestest
Created: 5/13/2025
Status: ✅ Merged
Merged: 5/13/2025
Merged by: @mnadareski

Base: master ← Head: improve-cd-dvd-cops

---

📝 Commits (4)

• f8f73c2 Improve detection for cd/dvd-cops version string
• 65a92c7 I forgot to include the regex compensation for comma version number cases
• 93fd8cf Pasted comment wrong previously
• f566fd5 Implemented Sabre's review fixes, also added check for Codefree

📊 Changes

2 files changed (+80 additions, -41 deletions)

View changed files

📝 BinaryObjectScanner.Test/Protection/CDDVDCopsTests.cs (+0 -11)
📝 BinaryObjectScanner/Protection/CDDVDCops.cs (+80 -30)

📄 Description

This removes the content check, moves the NE checks to the NE check section, and adds a PE check for the single currently confirmed section.

One thing I was wondering- what's with the "(Unconfirmed - Please report to us on Github)" parts? They seem pretty confirmed, even being in existing redump entries. Is it supposed to be a placeholder for a safedisc-style version table?

/home/bestest/cdCopsSamples/2002MM/BMM.exe: DVD-Cops (Unconfirmed - Please report to us on Github) 2.01
/home/bestest/cdCopsSamples/2003MM/bmm.exe: DVD-Cops (Unconfirmed - Please report to us on Github) 1,60
/home/bestest/cdCopsSamples/aHugEu/AgentHugo.exe: CD-Cops (Unconfirmed - Please report to us on Github) 1,08
/home/bestest/cdCopsSamples/bib/bib.dll: CD-Cops 1.95
/home/bestest/cdCopsSamples/mofamen/h3blade.exe: CD-Cops (Unconfirmed - Please report to us on Github) 1.72

Fixes https://github.com/SabreTools/BinaryObjectScanner/issues/367

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/BinaryObjectScanner/pull/368 **Author:** [@HeroponRikiBestest](https://github.com/HeroponRikiBestest) **Created:** 5/13/2025 **Status:** ✅ Merged **Merged:** 5/13/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `improve-cd-dvd-cops` --- ### 📝 Commits (4) - [`f8f73c2`](https://github.com/SabreTools/BinaryObjectScanner/commit/f8f73c27e28d30d0dce14680b776999313f4c4cb) Improve detection for cd/dvd-cops version string - [`65a92c7`](https://github.com/SabreTools/BinaryObjectScanner/commit/65a92c79f12326a68bb3eca40520bdeb2bbc4863) I forgot to include the regex compensation for comma version number cases - [`93fd8cf`](https://github.com/SabreTools/BinaryObjectScanner/commit/93fd8cf58696e895c3f711628f19672575e6204f) Pasted comment wrong previously - [`f566fd5`](https://github.com/SabreTools/BinaryObjectScanner/commit/f566fd51455cc6182abcaa9fcff8f7f77fe44c95) Implemented Sabre's review fixes, also added check for Codefree ### 📊 Changes **2 files changed** (+80 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `BinaryObjectScanner.Test/Protection/CDDVDCopsTests.cs` (+0 -11) 📝 `BinaryObjectScanner/Protection/CDDVDCops.cs` (+80 -30) </details> ### 📄 Description This removes the content check, moves the NE checks to the NE check section, and adds a PE check for the single currently confirmed section. One thing I was wondering- what's with the "(Unconfirmed - Please report to us on Github)" parts? They seem pretty confirmed, even being in existing redump entries. Is it supposed to be a placeholder for a safedisc-style version table? ``` /home/bestest/cdCopsSamples/2002MM/BMM.exe: DVD-Cops (Unconfirmed - Please report to us on Github) 2.01 /home/bestest/cdCopsSamples/2003MM/bmm.exe: DVD-Cops (Unconfirmed - Please report to us on Github) 1,60 /home/bestest/cdCopsSamples/aHugEu/AgentHugo.exe: CD-Cops (Unconfirmed - Please report to us on Github) 1,08 /home/bestest/cdCopsSamples/bib/bib.dll: CD-Cops 1.95 /home/bestest/cdCopsSamples/mofamen/h3blade.exe: CD-Cops (Unconfirmed - Please report to us on Github) 1.72 ``` Fixes https://github.com/SabreTools/BinaryObjectScanner/issues/367 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:09:53 +00:00

claunia closed this issue 2026-01-29 21:09:54 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.5.0

3.4.6

3.4.5

3.4.4

3.4.3

3.4.2

3.4.1

3.4.0

3.3.4

3.3.3

3.3.2

3.3.1

3.3.0

3.2.3

3.2.2

3.2.1

3.2.0

3.1.16

3.1.15

3.1.14

3.1.13

3.1.12

3.1.11

3.1.10

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

3.1.1

3.1.0

3.0.2

3.0.1

3.0.0

2.9.0

2.8.0

2.7.0

2.6.0

2.5.0

2.3.4

2.3.3

2.3.2

2.3.1

2.3.0

2.1.0

2.0.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.1

1.5.0

1.4.1

1.4.0

1.03.9.1

1.03.9

1.03.8.2

1.03.8.1

1.03.8.0

1.03.7.1

1.03.5

1.03.7

1.03.6

Labels

Clear labels

bug

enhancement

help wanted

pull-request

Mirrored from GitHub Pull Request

question

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/BinaryObjectScanner#521