[PR #375] [MERGED] Add branching and specific SharpCompress calls for solid vs non-solid archives in order to extract solid archives properly. #526

New Issue

claunia · 2026-01-29T21:09:56Z

claunia commented

2026-01-29 21:09:56 +00:00

📋 Pull Request Information

Original PR: https://github.com/SabreTools/BinaryObjectScanner/pull/375
Author: @HeroponRikiBestest
Created: 7/12/2025
Status: ✅ Merged
Merged: 7/12/2025
Merged by: @mnadareski

Base: master ← Head: solid-archive-speedfix

📝 Commits (6)

ecd99b1 Add branching for solid vs non-solid archives in order to extract solid archives properly.
26c1e88 Change comments on sevenzip, reuse archive-level solid flag for rar
df38bf3 Fully simplify identifying if archive is solid.
eca101b Finish implementing first round of feedback.
6460684 Fix second round of formatting issues.
c37dbc7 Final formatting fixes.

📊 Changes

2 files changed (+144 additions, -60 deletions)

View changed files

📝 BinaryObjectScanner/FileType/RAR.cs (+72 -30)
📝 BinaryObjectScanner/FileType/SevenZip.cs (+72 -30)

📄 Description

At the moment, BOS will practically speaking freeze on any solid 7z or RAR file, as they need to be decompressed sequentially in order for extraction to occur in any reasonable time. This PR adds pathing and specific code to detect solid vs non-solid 7Z and RAR archives, and extract them accordingly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/BinaryObjectScanner/pull/375 **Author:** [@HeroponRikiBestest](https://github.com/HeroponRikiBestest) **Created:** 7/12/2025 **Status:** ✅ Merged **Merged:** 7/12/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `solid-archive-speedfix` --- ### 📝 Commits (6) - [`ecd99b1`](https://github.com/SabreTools/BinaryObjectScanner/commit/ecd99b157db50c34cd0c91fa36ffde9f9c9b10e3) Add branching for solid vs non-solid archives in order to extract solid archives properly. - [`26c1e88`](https://github.com/SabreTools/BinaryObjectScanner/commit/26c1e88b9de140db313eb2a1b2a808c2ff18ec86) Change comments on sevenzip, reuse archive-level solid flag for rar - [`df38bf3`](https://github.com/SabreTools/BinaryObjectScanner/commit/df38bf3d8b3977d28b65eb4512617fce01ad8047) Fully simplify identifying if archive is solid. - [`eca101b`](https://github.com/SabreTools/BinaryObjectScanner/commit/eca101b935e45f4801b897e94ce985cc76c87604) Finish implementing first round of feedback. - [`6460684`](https://github.com/SabreTools/BinaryObjectScanner/commit/6460684bdce03472961a6d711fd6fc3edc592e45) Fix second round of formatting issues. - [`c37dbc7`](https://github.com/SabreTools/BinaryObjectScanner/commit/c37dbc7014e233bec285f54cc0b2dc2c38f24bc1) Final formatting fixes. ### 📊 Changes **2 files changed** (+144 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `BinaryObjectScanner/FileType/RAR.cs` (+72 -30) 📝 `BinaryObjectScanner/FileType/SevenZip.cs` (+72 -30) </details> ### 📄 Description At the moment, BOS will practically speaking freeze on any solid 7z or RAR file, as they need to be decompressed sequentially in order for extraction to occur in any reasonable time. This PR adds pathing and specific code to detect solid vs non-solid 7Z and RAR archives, and extract them accordingly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 21:09:56 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/BinaryObjectScanner#526