[PR #379] [MERGED] Move PA Module detection into its own helper method. #527

New Issue

Closed

opened 2026-01-29 21:09:56 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:09:56 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/BinaryObjectScanner/pull/379
Author: @HeroponRikiBestest
Created: 9/8/2025
Status: ✅ Merged
Merged: 9/8/2025
Merged by: @mnadareski

Base: master ← Head: pa-module-helper

---

📝 Commits (2)

• 5f966b5 Move PA Module detection into its own helper method.
• c4a278a Fix review changes.

📊 Changes

1 file changed (+53 additions, -38 deletions)

View changed files

📝 BinaryObjectScanner/Protection/SecuROM.cs (+53 -38)

📄 Description

Self-explanatory; all these checks are separate from the actual securom executable anyways, and this will help with a future PA pr i have in mind.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/BinaryObjectScanner/pull/379 **Author:** [@HeroponRikiBestest](https://github.com/HeroponRikiBestest) **Created:** 9/8/2025 **Status:** ✅ Merged **Merged:** 9/8/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `pa-module-helper` --- ### 📝 Commits (2) - [`5f966b5`](https://github.com/SabreTools/BinaryObjectScanner/commit/5f966b56dab118c8a18f15d8f6e9d810b3a16cfc) Move PA Module detection into its own helper method. - [`c4a278a`](https://github.com/SabreTools/BinaryObjectScanner/commit/c4a278abf40811209f26fc10a73709a95749f265) Fix review changes. ### 📊 Changes **1 file changed** (+53 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `BinaryObjectScanner/Protection/SecuROM.cs` (+53 -38) </details> ### 📄 Description Self-explanatory; all these checks are separate from the actual securom executable anyways, and this will help with a future PA pr i have in mind. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:09:56 +00:00

claunia closed this issue 2026-01-29 21:09:56 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.5.0

3.4.6

3.4.5

3.4.4

3.4.3

3.4.2

3.4.1

3.4.0

3.3.4

3.3.3

3.3.2

3.3.1

3.3.0

3.2.3

3.2.2

3.2.1

3.2.0

3.1.16

3.1.15

3.1.14

3.1.13

3.1.12

3.1.11

3.1.10

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

3.1.1

3.1.0

3.0.2

3.0.1

3.0.0

2.9.0

2.8.0

2.7.0

2.6.0

2.5.0

2.3.4

2.3.3

2.3.2

2.3.1

2.3.0

2.1.0

2.0.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.1

1.5.0

1.4.1

1.4.0

1.03.9.1

1.03.9

1.03.8.2

1.03.8.1

1.03.8.0

1.03.7.1

1.03.5

1.03.7

1.03.6

Labels

Clear labels

bug

enhancement

help wanted

pull-request

Mirrored from GitHub Pull Request

question

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/BinaryObjectScanner#527