mirror of
https://github.com/SabreTools/BinaryObjectScanner.git
synced 2026-02-03 21:29:23 +00:00
[PR #374] Fixes .hdr+.cab installshield cabinet files not being extracted by BOS when relative paths are provided. #528
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/SabreTools/BinaryObjectScanner/pull/374
State: closed
Merged: Yes
Installshield .hdr+.cab archives were not being extracted by BOS when relative paths were provided. Let me know if this is an improper fix- I tried to look for similar functions in other extractors, but as far as I can tell, nothing else is written exactly like this bit.
Apologies for closing and re-opening the pull request, but since this is a problem that affects no other part of BOS and is unique to this specific part of ISCAB due to nothing else working like it, I had assumed i was fine to just commit directly to master and it would be a quick merge. It's understandable that this might need further investigation, but I need to make other PRs and I don't want to destroy my own git history, so I had to move my commits to a different branch and roll back master after the fact.