SabreTools/BinaryObjectScanner
1
0
Fork 0
mirror of https://github.com/SabreTools/BinaryObjectScanner.git synced 2026-02-04 05:35:49 +00:00
Code Issues 295 Packages Projects Releases 20 Wiki Activity

[PR #389] [MERGED] Initial ISO Protection Detection #533

New Issue
Closed
opened 2026-01-29 21:11:04 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 21:11:04 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/BinaryObjectScanner/pull/389
Author: @HeroponRikiBestest
Created: 10/30/2025
Status: ✅ Merged
Merged: 11/7/2025
Merged by: @mnadareski

Base: master ← Head: iso-protection-detection

📝 Commits (10+)

📊 Changes

26 files changed (+932 additions, -17 deletions)

View changed files

📝 BinaryObjectScanner.Test/BinaryObjectScanner.Test.csproj (+3 -3)
➕ BinaryObjectScanner.Test/FileType/DiskImageTests.cs (+34 -0)
📝 BinaryObjectScanner.Test/Protection/AlphaROMTests.cs (+13 -0)
📝 BinaryObjectScanner.Test/Protection/CopyLokTests.cs (+13 -0)
📝 BinaryObjectScanner.Test/Protection/LaserLokTests.cs (+13 -0)
📝 BinaryObjectScanner.Test/Protection/MacrovisionTests.cs (+13 -0)
📝 BinaryObjectScanner.Test/Protection/ProtectDiscTests.cs (+13 -0)
📝 BinaryObjectScanner.Test/Protection/SecuROMTests.cs (+13 -0)
📝 BinaryObjectScanner.Test/Protection/StarForceTests.cs (+13 -0)
📝 BinaryObjectScanner.Test/Protection/TAGESTests.cs (+13 -0)
📝 BinaryObjectScanner/BinaryObjectScanner.csproj (+3 -3)
📝 BinaryObjectScanner/Data/StaticChecks.cs (+18 -0)
➕ BinaryObjectScanner/FileType/DiskImage.cs (+51 -0)
📝 BinaryObjectScanner/FileType/Executable.cs (+0 -1)
➕ BinaryObjectScanner/FileType/ISO9660.cs (+130 -0)
➕ BinaryObjectScanner/Interfaces/IDiskImageCheck.cs (+19 -0)
📝 BinaryObjectScanner/Protection/AlphaROM.cs (+52 -2)
📝 BinaryObjectScanner/Protection/CopyLok.cs (+89 -1)
📝 BinaryObjectScanner/Protection/LaserLok.cs (+44 -1)
📝 BinaryObjectScanner/Protection/Macrovision.cs (+73 -1)

...and 6 more files

📄 Description

Currently a draft PR for showcase purposes, will be un-drafted once all protections are added (and Serialization is bumped, but that will most likely happen first).

I know it should return null instead of "None", the "None" is just there for testing reasons atm.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/BinaryObjectScanner/pull/389 **Author:** [@HeroponRikiBestest](https://github.com/HeroponRikiBestest) **Created:** 10/30/2025 **Status:** ✅ Merged **Merged:** 11/7/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `iso-protection-detection` --- ### 📝 Commits (10+) - [`0ca0a84`](https://github.com/SabreTools/BinaryObjectScanner/commit/0ca0a8457e17e66227ed2dcd1d5eb2c6640f6995) Initial - [`ca9f667`](https://github.com/SabreTools/BinaryObjectScanner/commit/ca9f667f5fc18fd148ba212ebd16aefc40570ba8) Laserlock in - [`ec76f82`](https://github.com/SabreTools/BinaryObjectScanner/commit/ec76f82a8f58d53b1eab89d379f3327342a03f31) This is a better way to read the string - [`f1374a7`](https://github.com/SabreTools/BinaryObjectScanner/commit/f1374a7b97f4f6f1f7904b5149dfe220d3a821a9) That array copy wasn't needed either - [`4871899`](https://github.com/SabreTools/BinaryObjectScanner/commit/48718993f7907a489b7cf8ccfcef64b904bf65d3) Use static filetype method, rename filetype.iso - [`495e220`](https://github.com/SabreTools/BinaryObjectScanner/commit/495e22071d98d786a9ae0180d13dd606b41d3a0c) Initial Codelok ISO scanning - [`0bb0285`](https://github.com/SabreTools/BinaryObjectScanner/commit/0bb0285b068d1fe8d7350947d0caf9ac6d5fb06b) Comments with redump IDs - [`55ebf89`](https://github.com/SabreTools/BinaryObjectScanner/commit/55ebf898aa37df3c1e86753eba45a8fa1b23d768) Add redump examples to laserlock - [`571e639`](https://github.com/SabreTools/BinaryObjectScanner/commit/571e639f49ff30b412b0e51bdbb23399dec8ba05) Change for testing - [`33040b8`](https://github.com/SabreTools/BinaryObjectScanner/commit/33040b86dac0eab0b2525632f28eb27ead02cd91) Small comment ### 📊 Changes **26 files changed** (+932 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `BinaryObjectScanner.Test/BinaryObjectScanner.Test.csproj` (+3 -3) ➕ `BinaryObjectScanner.Test/FileType/DiskImageTests.cs` (+34 -0) 📝 `BinaryObjectScanner.Test/Protection/AlphaROMTests.cs` (+13 -0) 📝 `BinaryObjectScanner.Test/Protection/CopyLokTests.cs` (+13 -0) 📝 `BinaryObjectScanner.Test/Protection/LaserLokTests.cs` (+13 -0) 📝 `BinaryObjectScanner.Test/Protection/MacrovisionTests.cs` (+13 -0) 📝 `BinaryObjectScanner.Test/Protection/ProtectDiscTests.cs` (+13 -0) 📝 `BinaryObjectScanner.Test/Protection/SecuROMTests.cs` (+13 -0) 📝 `BinaryObjectScanner.Test/Protection/StarForceTests.cs` (+13 -0) 📝 `BinaryObjectScanner.Test/Protection/TAGESTests.cs` (+13 -0) 📝 `BinaryObjectScanner/BinaryObjectScanner.csproj` (+3 -3) 📝 `BinaryObjectScanner/Data/StaticChecks.cs` (+18 -0) ➕ `BinaryObjectScanner/FileType/DiskImage.cs` (+51 -0) 📝 `BinaryObjectScanner/FileType/Executable.cs` (+0 -1) ➕ `BinaryObjectScanner/FileType/ISO9660.cs` (+130 -0) ➕ `BinaryObjectScanner/Interfaces/IDiskImageCheck.cs` (+19 -0) 📝 `BinaryObjectScanner/Protection/AlphaROM.cs` (+52 -2) 📝 `BinaryObjectScanner/Protection/CopyLok.cs` (+89 -1) 📝 `BinaryObjectScanner/Protection/LaserLok.cs` (+44 -1) 📝 `BinaryObjectScanner/Protection/Macrovision.cs` (+73 -1) _...and 6 more files_ </details> ### 📄 Description Currently a draft PR for showcase purposes, will be un-drafted once all protections are added (and Serialization is bumped, but that will most likely happen first). I know it should return `null` instead of "None", the "None" is just there for testing reasons atm. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 21:11:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/BinaryObjectScanner#533
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?