[PR #396] [MERGED] Improve starforce keyless detection #541

New Issue

Closed

opened 2026-01-29 21:11:09 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:11:09 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/BinaryObjectScanner/pull/396
Author: @HeroponRikiBestest
Created: 11/18/2025
Status: ✅ Merged
Merged: 11/18/2025
Merged by: @mnadareski

Base: master ← Head: starforce-keyless-improvement

---

📝 Commits (1)

• 6f4721b Improve starforce keyless detection

📊 Changes

1 file changed (+39 additions, -45 deletions)

View changed files

📝 BinaryObjectScanner/Protection/StarForce.cs (+39 -45)

📄 Description

The 4-byte value I was checking for in the PVD data isn't always there on starforce keyless discs, and the last improvements I did to the starforce keyless key regexes mean that they won't let any false positives through. Moving that bit of logic afterwards means that BOS will no longer miss a bunch of starforce keyless discs that it was missing before, and still with no false positives.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/BinaryObjectScanner/pull/396 **Author:** [@HeroponRikiBestest](https://github.com/HeroponRikiBestest) **Created:** 11/18/2025 **Status:** ✅ Merged **Merged:** 11/18/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `starforce-keyless-improvement` --- ### 📝 Commits (1) - [`6f4721b`](https://github.com/SabreTools/BinaryObjectScanner/commit/6f4721b8b5d4bd369ebf9aa7756a8aa9957b72da) Improve starforce keyless detection ### 📊 Changes **1 file changed** (+39 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `BinaryObjectScanner/Protection/StarForce.cs` (+39 -45) </details> ### 📄 Description The 4-byte value I was checking for in the PVD data isn't always there on starforce keyless discs, and the last improvements I did to the starforce keyless key regexes mean that they won't let any false positives through. Moving that bit of logic afterwards means that BOS will no longer miss a bunch of starforce keyless discs that it was missing before, and still with no false positives. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:11:09 +00:00

claunia closed this issue 2026-01-29 21:11:10 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.5.0

3.4.6

3.4.5

3.4.4

3.4.3

3.4.2

3.4.1

3.4.0

3.3.4

3.3.3

3.3.2

3.3.1

3.3.0

3.2.3

3.2.2

3.2.1

3.2.0

3.1.16

3.1.15

3.1.14

3.1.13

3.1.12

3.1.11

3.1.10

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

3.1.1

3.1.0

3.0.2

3.0.1

3.0.0

2.9.0

2.8.0

2.7.0

2.6.0

2.5.0

2.3.4

2.3.3

2.3.2

2.3.1

2.3.0

2.1.0

2.0.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.1

1.5.0

1.4.1

1.4.0

1.03.9.1

1.03.9

1.03.8.2

1.03.8.1

1.03.8.0

1.03.7.1

1.03.5

1.03.7

1.03.6

Labels

Clear labels

bug

enhancement

help wanted

pull-request

Mirrored from GitHub Pull Request

question

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/BinaryObjectScanner#541