From 0afb49b6570597f27aa3dfe807e160feb4dcd76b Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Sat, 10 Jun 2023 18:01:52 -0400 Subject: [PATCH] Add TODO with notes to Redumper --- CHANGELIST.md | 1 + MPF.Modules/Redumper/Parameters.cs | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/CHANGELIST.md b/CHANGELIST.md index cabdf341..124ff627 100644 --- a/CHANGELIST.md +++ b/CHANGELIST.md @@ -62,6 +62,7 @@ - Unblock Redumper DVD support - Support Redumper DVD layerbreak - Add placeholder and TODOs for Redumper +- Add TODO with notes to Redumper ### 2.5 (2023-03-12) diff --git a/MPF.Modules/Redumper/Parameters.cs b/MPF.Modules/Redumper/Parameters.cs index 6f09ac0d..2eeb5beb 100644 --- a/MPF.Modules/Redumper/Parameters.cs +++ b/MPF.Modules/Redumper/Parameters.cs @@ -180,6 +180,10 @@ namespace MPF.Modules.Redumper /// public override (bool, List) CheckAllOutputFilesExist(string basePath, bool preCheck) { + // TODO: Also check for incomplete files, if possible + // All files should be generated at the beginning of a dump, so it is difficult to know if anything is missing + // Potentially looking inside of the `log` file, if it exists, would be useful + // Another option could be the presence of the DAT section, since it's not a separate file here List missingFiles = new List(); switch (this.Type)