diff --git a/CHANGELIST.md b/CHANGELIST.md index 5fb0c3a2..5abb4c65 100644 --- a/CHANGELIST.md +++ b/CHANGELIST.md @@ -44,6 +44,7 @@ - Add Int32 array input type - Wire up input boundaries - Fix required Int32 array input +- Ensure dumping commands are tested ### 3.2.4 (2024-11-24) diff --git a/MPF.ExecutionContexts.Test/AaruTests.cs b/MPF.ExecutionContexts.Test/AaruTests.cs index c3e76c56..ac971431 100644 --- a/MPF.ExecutionContexts.Test/AaruTests.cs +++ b/MPF.ExecutionContexts.Test/AaruTests.cs @@ -39,6 +39,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -54,6 +55,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -67,6 +69,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -84,6 +87,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -95,6 +99,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -112,6 +117,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -137,6 +143,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -158,6 +165,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -191,6 +199,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -203,6 +212,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -232,6 +242,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -245,6 +256,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -262,6 +274,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -279,6 +292,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -296,6 +310,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -313,6 +328,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -324,6 +340,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -335,6 +352,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -352,6 +370,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -369,6 +388,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -390,6 +410,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } [Theory] @@ -403,6 +424,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -420,6 +442,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -435,6 +458,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } [Theory] @@ -448,6 +472,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion diff --git a/MPF.ExecutionContexts.Test/DiscImageCreatorTests.cs b/MPF.ExecutionContexts.Test/DiscImageCreatorTests.cs index cb967851..9b3d0c85 100644 --- a/MPF.ExecutionContexts.Test/DiscImageCreatorTests.cs +++ b/MPF.ExecutionContexts.Test/DiscImageCreatorTests.cs @@ -49,6 +49,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -63,6 +64,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -77,6 +79,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -91,6 +94,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -105,6 +109,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -119,6 +124,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -133,6 +139,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -147,6 +154,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -161,6 +169,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -175,6 +184,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -189,6 +199,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -203,6 +214,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -217,6 +229,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -231,6 +244,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -245,6 +259,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -259,6 +274,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -273,6 +289,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -287,6 +304,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -301,6 +319,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -315,6 +334,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -329,6 +349,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -343,6 +364,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -357,6 +379,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -371,6 +394,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -385,6 +409,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion diff --git a/MPF.ExecutionContexts.Test/RedumperTests.cs b/MPF.ExecutionContexts.Test/RedumperTests.cs index 7465bcc3..d66c8b72 100644 --- a/MPF.ExecutionContexts.Test/RedumperTests.cs +++ b/MPF.ExecutionContexts.Test/RedumperTests.cs @@ -37,6 +37,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -52,6 +53,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -67,6 +69,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -82,6 +85,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -97,6 +101,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -112,6 +117,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -127,6 +133,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -142,6 +149,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.True(context.IsDumpingCommand()); } #endregion @@ -157,6 +165,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -172,6 +181,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -187,6 +197,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -202,6 +213,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -217,6 +229,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -232,6 +245,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -247,6 +261,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -262,6 +277,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -277,6 +293,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -292,6 +309,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -307,6 +325,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion @@ -322,6 +341,7 @@ namespace MPF.ExecutionContexts.Test var context = new ExecutionContext(parameters); string? actual = context.GenerateParameters(); Assert.Equal(expected, actual); + Assert.False(context.IsDumpingCommand()); } #endregion diff --git a/MPF.ExecutionContexts/Redumper/ExecutionContext.cs b/MPF.ExecutionContexts/Redumper/ExecutionContext.cs index 8eb7f372..af1b1758 100644 --- a/MPF.ExecutionContexts/Redumper/ExecutionContext.cs +++ b/MPF.ExecutionContexts/Redumper/ExecutionContext.cs @@ -225,14 +225,13 @@ namespace MPF.ExecutionContexts.Redumper /// public override bool IsDumpingCommand() { - return BaseCommand == CommandStrings.NONE - || BaseCommand?.Contains(CommandStrings.CD) == true - || BaseCommand?.Contains(CommandStrings.DVD) == true - || BaseCommand?.Contains(CommandStrings.BluRay) == true - || BaseCommand?.Contains(CommandStrings.SACD) == true - || BaseCommand?.Contains(CommandStrings.New) == true - || BaseCommand?.Contains(CommandStrings.Dump) == true - || BaseCommand?.Contains(CommandStrings.DumpNew) == true; + return ModeValues?.Contains(CommandStrings.CD) == true + || ModeValues?.Contains(CommandStrings.DVD) == true + || ModeValues?.Contains(CommandStrings.BluRay) == true + || ModeValues?.Contains(CommandStrings.SACD) == true + || ModeValues?.Contains(CommandStrings.New) == true + || ModeValues?.Contains(CommandStrings.Dump) == true + || ModeValues?.Contains(CommandStrings.DumpNew) == true; } ///