From 114c7fb38a57b231a533edd1eb6c89d8d8f259ad Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Wed, 2 Feb 2022 19:59:53 -0800 Subject: [PATCH] Make error clearer if something is unsupported in Check --- CHANGELIST.md | 1 + MPF.Modules/Aaru/Parameters.cs | 3 ++- MPF.Modules/CleanRIp/Parameters.cs | 3 ++- MPF.Modules/DiscImageCreator/Parameters.cs | 3 ++- MPF.Modules/UmdImageCreator/Parameters.cs | 3 ++- 5 files changed, 9 insertions(+), 4 deletions(-) diff --git a/CHANGELIST.md b/CHANGELIST.md index ab49b2e1..9e4f4308 100644 --- a/CHANGELIST.md +++ b/CHANGELIST.md @@ -76,6 +76,7 @@ - Ensure version only pulled if one doesn't exist - Ensure Games pseudo-tag is multi-line - Add alternate pseudo-tag for Playable Demos +- Make error clearer if something is unsupported in Check ### 2.2 (2021-12-30) - Fix Saturn header finding diff --git a/MPF.Modules/Aaru/Parameters.cs b/MPF.Modules/Aaru/Parameters.cs index 86022b78..cc8fb090 100644 --- a/MPF.Modules/Aaru/Parameters.cs +++ b/MPF.Modules/Aaru/Parameters.cs @@ -183,7 +183,8 @@ namespace MPF.Modules.Aaru break; default: - return (false, missingFiles); // TODO: Figure out more formats + missingFiles.Add("Media and system combination not supported for Aaru"); + break; } return (!missingFiles.Any(), missingFiles); diff --git a/MPF.Modules/CleanRIp/Parameters.cs b/MPF.Modules/CleanRIp/Parameters.cs index c26b38e9..b76e6f13 100644 --- a/MPF.Modules/CleanRIp/Parameters.cs +++ b/MPF.Modules/CleanRIp/Parameters.cs @@ -50,7 +50,8 @@ namespace MPF.Modules.CleanRip break; default: - return (false, missingFiles); + missingFiles.Add("Media and system combination not supported for CleanRip"); + break; } return (!missingFiles.Any(), missingFiles); diff --git a/MPF.Modules/DiscImageCreator/Parameters.cs b/MPF.Modules/DiscImageCreator/Parameters.cs index dc015000..6e596b09 100644 --- a/MPF.Modules/DiscImageCreator/Parameters.cs +++ b/MPF.Modules/DiscImageCreator/Parameters.cs @@ -346,7 +346,8 @@ namespace MPF.Modules.DiscImageCreator break; default: - return (false, missingFiles); + missingFiles.Add("Media and system combination not supported for DiscImageCreator"); + break; } return (!missingFiles.Any(), missingFiles); diff --git a/MPF.Modules/UmdImageCreator/Parameters.cs b/MPF.Modules/UmdImageCreator/Parameters.cs index ea9cd417..c0a8b24f 100644 --- a/MPF.Modules/UmdImageCreator/Parameters.cs +++ b/MPF.Modules/UmdImageCreator/Parameters.cs @@ -52,7 +52,8 @@ namespace MPF.Modules.UmdImageCreator break; default: - return (false, missingFiles); + missingFiles.Add("Media and system combination not supported for UmdImageCreator"); + break; } return (!missingFiles.Any(), missingFiles);