From 5f760800eb6da17b3e0463048db6faa554279afc Mon Sep 17 00:00:00 2001 From: Deterous <138427222+Deterous@users.noreply.github.com> Date: Tue, 17 Mar 2026 23:50:12 +0900 Subject: [PATCH] Only print BCA for nintendo dumps (#959) --- CHANGELIST.md | 1 + MPF.Processors/Redumper.cs | 13 +++++++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/CHANGELIST.md b/CHANGELIST.md index 11b02b4a..c7d9cf69 100644 --- a/CHANGELIST.md +++ b/CHANGELIST.md @@ -70,6 +70,7 @@ - Fix XGD3 SS validity check - Update Portuguese translation - Compress fixed SS +- Only print BCA for nintendo dumps ### 3.6.0 (2025-11-28) diff --git a/MPF.Processors/Redumper.cs b/MPF.Processors/Redumper.cs index b2b837a1..6d56bc1b 100644 --- a/MPF.Processors/Redumper.cs +++ b/MPF.Processors/Redumper.cs @@ -213,8 +213,9 @@ namespace MPF.Processors long scsiErrors = GetSCSIErrorCount($"{basePath}.log"); info.CommonDiscInfo.ErrorsCount = scsiErrors == -1 ? "Error retrieving error count" : scsiErrors.ToString(); - // Get BCA information, if available - info.Extras.BCA = GetBCA($"{basePath}.bca"); + // Get BCA information, if available, for Nintendo discs only + if (mediaType == MediaType.NintendoGameCubeGameDisc || mediaType == MediaType.NintendoWiiOpticalDisc) + info.Extras.BCA = GetBCA($"{basePath}.bca"); // Bluray-specific options if (mediaType == MediaType.BluRay || mediaType == MediaType.NintendoWiiUOpticalDisc) @@ -373,6 +374,10 @@ namespace MPF.Processors info.VersionAndEditions.Version = gcVersion ?? info.VersionAndEditions.Version; } + // Get BCA information, if available, and not already set + if (!string.IsNullOrEmpty(info.Extras.BCA)) + info.Extras.BCA = GetBCA($"{basePath}.bca"); + break; case RedumpSystem.SegaMegaCDSegaCD: @@ -989,8 +994,8 @@ namespace MPF.Processors "HD DVD-RAM" => MediaType.HDDVD, "HD DVD-R" => MediaType.HDDVD, - "NINTENDO" => MediaType.NintendoWiiOpticalDisc, // Maybe also GC? - "RESERVED5" => MediaType.NintendoWiiOpticalDisc, // Maybe also GC? + "NINTENDO" => MediaType.NintendoWiiOpticalDisc, // Also GC + "RESERVED5" => MediaType.NintendoWiiOpticalDisc, // Also GC "RESERVED1" => null, "RESERVED2" => null,