From 8f6f5f6ef0f5b4f40e1ade4cbdb36fa08a838aff Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Fri, 18 Jul 2025 15:09:21 -0400 Subject: [PATCH] UI consistency when parameters are editable (fixes #876) --- CHANGELIST.md | 1 + MPF.Frontend/ViewModels/MainViewModel.cs | 19 ++----------------- 2 files changed, 3 insertions(+), 17 deletions(-) diff --git a/CHANGELIST.md b/CHANGELIST.md index 2f49d3f5..ae15721b 100644 --- a/CHANGELIST.md +++ b/CHANGELIST.md @@ -2,6 +2,7 @@ - Remove media type from Check Dump UI - Always trust the output files for processing +- UI consistency when parameters are editable ### 3.3.3 (2025-07-18) diff --git a/MPF.Frontend/ViewModels/MainViewModel.cs b/MPF.Frontend/ViewModels/MainViewModel.cs index fbdfa83f..42985795 100644 --- a/MPF.Frontend/ViewModels/MainViewModel.cs +++ b/MPF.Frontend/ViewModels/MainViewModel.cs @@ -2190,23 +2190,6 @@ namespace MPF.Frontend.ViewModels // Force an internal drive refresh in case the user entered things manually _environment.RefreshDrive(); - // If still in custom parameter mode, check that users meant to continue or not - if (ParametersCheckBoxEnabled == false && _displayUserMessage != null) - { - bool? result = _displayUserMessage("Custom Changes", "It looks like you have custom parameters that have not been saved. Would you like to dump with these custom parameters?", 2, true); - if (result == true) - { - ParametersCheckBoxEnabled = true; - ProcessCustomParameters(); - } - else - { - // Re-allow quick exiting - AskBeforeQuit = false; - return; - } - } - try { // Run pre-dumping validation checks @@ -2303,6 +2286,7 @@ namespace MPF.Frontend.ViewModels MediaScanButtonEnabled = false; UpdateVolumeLabelEnabled = false; CopyProtectScanButtonEnabled = false; + StartStopButtonEnabled = false; } else { @@ -2323,6 +2307,7 @@ namespace MPF.Frontend.ViewModels MediaScanButtonEnabled = true; UpdateVolumeLabelEnabled = true; CopyProtectScanButtonEnabled = true; + StartStopButtonEnabled = true; } }