From fca2c53d6c82980faaed9a6c8c847dfc642dbcb1 Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Sat, 19 Jul 2025 09:06:28 -0400 Subject: [PATCH] Let the processor always deal with unsupported --- CHANGELIST.md | 1 + MPF.Frontend/Tools/SubmissionGenerator.cs | 10 +++------- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/CHANGELIST.md b/CHANGELIST.md index ae15721b..06923555 100644 --- a/CHANGELIST.md +++ b/CHANGELIST.md @@ -3,6 +3,7 @@ - Remove media type from Check Dump UI - Always trust the output files for processing - UI consistency when parameters are editable +- Let the processor always deal with unsupported ### 3.3.3 (2025-07-18) diff --git a/MPF.Frontend/Tools/SubmissionGenerator.cs b/MPF.Frontend/Tools/SubmissionGenerator.cs index 5569dbb2..09e627e1 100644 --- a/MPF.Frontend/Tools/SubmissionGenerator.cs +++ b/MPF.Frontend/Tools/SubmissionGenerator.cs @@ -51,10 +51,6 @@ namespace MPF.Frontend.Tools IProgress? resultProgress = null, IProgress? protectionProgress = null) { - // Ensure the current disc combination should exist - if (!system.MediaTypes().Contains(mediaType)) - return null; - // Split the output path for easier use var outputDirectory = Path.GetDirectoryName(outputPath); string outputFilename = Path.GetFileName(outputPath); @@ -77,9 +73,9 @@ namespace MPF.Frontend.Tools SubmissionInfo info = CreateDefaultSubmissionInfo(processor, system, mediaType, options.AddPlaceholders); // Get specific tool output handling - processor?.GenerateSubmissionInfo(info, mediaType, basePath, options.EnableRedumpCompatibility); + processor.GenerateSubmissionInfo(info, mediaType, basePath, options.EnableRedumpCompatibility); if (options.IncludeArtifacts) - info.Artifacts = processor?.GenerateArtifacts(mediaType, outputDirectory, outputFilename); + info.Artifacts = processor.GenerateArtifacts(mediaType, outputDirectory, outputFilename); // Add a placeholder for the logs link info.CommonDiscInfo!.CommentsSpecialFields![SiteCode.LogsLink] = "[Please provide a link to your logs here]"; @@ -93,7 +89,7 @@ namespace MPF.Frontend.Tools info.TracksAndWriteOffsets.ClrMameProData = null; // Add the volume label to comments, if possible or necessary - string? volLabels = FormatVolumeLabels(drive?.VolumeLabel, processor?.VolumeLabels); + string? volLabels = FormatVolumeLabels(drive?.VolumeLabel, processor.VolumeLabels); if (volLabels != null) info.CommonDiscInfo!.CommentsSpecialFields![SiteCode.VolumeLabel] = volLabels;