SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #324] [MERGED] Fix various arcade system metadata issues #1000

New Issue
Closed
opened 2026-01-29 16:24:45 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:45 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/324
Author: @shizmob
Created: 10/26/2021
Status: ✅ Merged
Merged: 10/26/2021
Merged by: @mnadareski

Base: master ← Head: fix/arcade-system-metadata

📝 Commits (4)

  • e603d84 redumplib: correct media type for Sega Nu
  • 3e77d1c redumplib: merge Namco System 246 and System 256
  • 8e636b0 redumplib: drop Namco System 357 / 369
  • d5e8181 redumplib: add SEGA ALLS

📊 Changes

3 files changed (+27 additions, -41 deletions)

View changed files

📝 MPF.Test/Utilities/ParametersTest.cs (+1 -1)
📝 RedumpLib/Data/Enumerations.cs (+5 -8)
📝 RedumpLib/Data/Extensions.cs (+21 -32)

📄 Description

  • The Triforce is generally considered a SEGA system, even if Namco made some PCBs for it. It has outer SEGA part/chassis numbers, runs SEGA firmware and software, uses SEGAs GD-ROM/DIMM game delivery system, and has SEGA manuals. Aside from some licensing and providing the base GameCube, Nintendo was uninvolved; Dropped as per comments below
  • Namco System 357 and System 369 are not disc-based systems and can not accept discs, so they don't really have a place here;
  • Namco System 246 and 256 are, for disc purposes, the same system. The Super System 256 does not accept discs;
  • The SEGA Nu takes DVDs, not blu-rays;
  • Add the SEGA ALLS, which takes DVDs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/324 **Author:** [@shizmob](https://github.com/shizmob) **Created:** 10/26/2021 **Status:** ✅ Merged **Merged:** 10/26/2021 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `fix/arcade-system-metadata` --- ### 📝 Commits (4) - [`e603d84`](https://github.com/SabreTools/MPF/commit/e603d84c957f2f15ef9b5d4835da49cfee35ace2) redumplib: correct media type for Sega Nu - [`3e77d1c`](https://github.com/SabreTools/MPF/commit/3e77d1caba2042b8949e047c37e63733b8382122) redumplib: merge Namco System 246 and System 256 - [`8e636b0`](https://github.com/SabreTools/MPF/commit/8e636b02417326e569d1ee86b415a4510802680e) redumplib: drop Namco System 357 / 369 - [`d5e8181`](https://github.com/SabreTools/MPF/commit/d5e81818deaef6e1d78b5d724af866eed4e83b73) redumplib: add SEGA ALLS ### 📊 Changes **3 files changed** (+27 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `MPF.Test/Utilities/ParametersTest.cs` (+1 -1) 📝 `RedumpLib/Data/Enumerations.cs` (+5 -8) 📝 `RedumpLib/Data/Extensions.cs` (+21 -32) </details> ### 📄 Description - ~~The Triforce is generally considered a SEGA system, even if Namco made some PCBs for it. It has outer SEGA part/chassis numbers, runs SEGA firmware and software, uses SEGAs GD-ROM/DIMM game delivery system, and has SEGA manuals. Aside from some licensing and providing the base GameCube, Nintendo was uninvolved;~~ Dropped as per comments below - Namco System 357 and System 369 are not disc-based systems and can not accept discs, so they don't really have a place here; - Namco System 246 and 256 are, for disc purposes, the same system. The Super System 256 does not accept discs; - The SEGA Nu takes DVDs, not blu-rays; - Add the SEGA ALLS, which takes DVDs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:45 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#1000
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?