[PR #445] [MERGED] Improve write offset detection for redumper #1020

New Issue

Closed

opened 2026-01-29 16:24:52 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:24:52 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/445
Author: @fuzz6001
Created: 12/30/2022
Status: ✅ Merged
Merged: 12/30/2022
Merged by: @mnadareski

Base: master ← Head: improve-write-offset-detection

---

📝 Commits (1)

• 7254a22 Skip during detection

📊 Changes

1 file changed (+7 additions, -6 deletions)

View changed files

📝 MPF.Modules/Redumper/Parameters.cs (+7 -6)

📄 Description

Skip all lines in the detection.

Some samples

Audio

detecting offset
audio silence detection... done
Perfect Audio Offset (silence level: 0): [-28707 .. +15478]
warning: fallback offset 0 applied
disc write offset: +0
detection complete (time: 15s)

Audio

detecting offset
audio silence detection... done
Perfect Audio Offset (silence level: 0): -12
Perfect Audio Offset applied
disc write offset: -12
detection complete (time: 17s)

PC

detecting offset
data track detected
disc write offset: -12
detection complete (time: 0s)

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/445 **Author:** [@fuzz6001](https://github.com/fuzz6001) **Created:** 12/30/2022 **Status:** ✅ Merged **Merged:** 12/30/2022 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `improve-write-offset-detection` --- ### 📝 Commits (1) - [`7254a22`](https://github.com/SabreTools/MPF/commit/7254a22b007b40e3cd078c42c99bec1d156ce43e) Skip during detection ### 📊 Changes **1 file changed** (+7 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `MPF.Modules/Redumper/Parameters.cs` (+7 -6) </details> ### 📄 Description Skip all lines in the detection. # Some samples ## Audio ``` detecting offset audio silence detection... done Perfect Audio Offset (silence level: 0): [-28707 .. +15478] warning: fallback offset 0 applied disc write offset: +0 detection complete (time: 15s) ``` ## Audio ``` detecting offset audio silence detection... done Perfect Audio Offset (silence level: 0): -12 Perfect Audio Offset applied disc write offset: -12 detection complete (time: 17s) ``` ## PC ``` detecting offset data track detected disc write offset: -12 detection complete (time: 0s) ``` --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:24:52 +00:00

claunia closed this issue 2026-01-29 16:24:52 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1020