[PR #568] [MERGED] Fix media combobox not updating #1046

New Issue

Closed

opened 2026-01-29 16:25:05 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:25:05 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/568
Author: @Deterous
Created: 10/10/2023
Status: ✅ Merged
Merged: 10/10/2023
Merged by: @mnadareski

Base: master ← Head: combobox

---

📝 Commits (3)

• 3bb041c Fix media combobox not updating
• 8b5d8cc Merge pull request #1 from SabreTools/master
• 5e8b182 Don't call SetCurrentDiscType rather than clear the variable

📊 Changes

1 file changed (+0 additions, -3 deletions)

View changed files

📝 MPF.Core/UI/ViewModels/MainViewModel.cs (+0 -3)

📄 Description

The media type combo box was not updating on user selection, due to the detected media type being chosen first.
I have solved this by clearing the detected media type variable once it has been used.

If you want to preserve the variable, then you can fix this a cleaner way, however pressing 'Scan for discs' does still revert the combo box to the detected media, so this change does do as expected.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/568 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 10/10/2023 **Status:** ✅ Merged **Merged:** 10/10/2023 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `combobox` --- ### 📝 Commits (3) - [`3bb041c`](https://github.com/SabreTools/MPF/commit/3bb041c33fbf4c0760129b55b332853a7eeb3d95) Fix media combobox not updating - [`8b5d8cc`](https://github.com/SabreTools/MPF/commit/8b5d8ccba52df4a8f0809d0d32fafed284f27ec4) Merge pull request #1 from SabreTools/master - [`5e8b182`](https://github.com/SabreTools/MPF/commit/5e8b182392cf41ad85d22dad8ab5782f4c025059) Don't call SetCurrentDiscType rather than clear the variable ### 📊 Changes **1 file changed** (+0 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `MPF.Core/UI/ViewModels/MainViewModel.cs` (+0 -3) </details> ### 📄 Description The media type combo box was not updating on user selection, due to the detected media type being chosen first. I have solved this by clearing the detected media type variable once it has been used. If you want to preserve the variable, then you can fix this a cleaner way, however pressing 'Scan for discs' does still revert the combo box to the detected media, so this change does do as expected. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:25:05 +00:00

claunia closed this issue 2026-01-29 16:25:05 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1046