[PR #577] [MERGED] Remove code for getting Universal Hash from DIC logs #1047

New Issue

Closed

opened 2026-01-29 16:25:05 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:25:05 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/577
Author: @Deterous
Created: 10/12/2023
Status: ✅ Merged
Merged: 10/13/2023
Merged by: @mnadareski

Base: master ← Head: dic-uh

---

📝 Commits (1)

• a8e4275 Remove code for getting UH from DIC logs

📊 Changes

1 file changed (+0 additions, -63 deletions)

View changed files

📝 MPF.Core/Modules/DiscImageCreator/Parameters.cs (+0 -63)

📄 Description

Fixes #506

• DIC logs for Audio CDs are no longer accepted by redump.org (this change only affects !submissionInfo.txt which is mostly used for redump submissions)
• For the universal hash to be accurate, DIC must have the disc write offset manually defined in /a flag
• DIC is not being updated in packaged MPF builds
• The currently packaged (and future) builds of DIC do not place the Universal Hash inside *_disc.txt so this code is not currently working correctly

For these reasons, it does not make sense to update or maintain this code, and since the code is now obsolete it should be removed.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/577 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 10/12/2023 **Status:** ✅ Merged **Merged:** 10/13/2023 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `dic-uh` --- ### 📝 Commits (1) - [`a8e4275`](https://github.com/SabreTools/MPF/commit/a8e4275edfdbfb1546baa3bdb6a3d9a9981d1758) Remove code for getting UH from DIC logs ### 📊 Changes **1 file changed** (+0 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `MPF.Core/Modules/DiscImageCreator/Parameters.cs` (+0 -63) </details> ### 📄 Description Fixes #506 - DIC logs for Audio CDs are no longer accepted by redump.org (this change only affects `!submissionInfo.txt` which is mostly used for redump submissions) - For the universal hash to be accurate, DIC must have the disc write offset manually defined in `/a` flag - DIC is not being updated in packaged MPF builds - The currently packaged (and future) builds of DIC do not place the Universal Hash inside *_disc.txt so this code is not currently working correctly For these reasons, it does not make sense to update or maintain this code, and since the code is now obsolete it should be removed. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:25:05 +00:00

claunia closed this issue 2026-01-29 16:25:05 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1047