[PR #589] [MERGED] Always use relative path internally #1049

New Issue

Open

opened 2026-01-29 16:25:06 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:25:06 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/589
Author: @Deterous
Created: 10/26/2023
Status: ✅ Merged
Merged: 10/26/2023
Merged by: @mnadareski

Base: master ← Head: relative-path

---

📝 Commits (1)

• c1d566a Use relative path internally

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 MPF.Core/DumpEnvironment.cs (+2 -2)
📝 MPF.Core/UI/ViewModels/MainViewModel.cs (+1 -1)

📄 Description

Set the getFullPath flags to false in the 3 places in MPF that still use full paths (except in MPF.Test).

I have tested this for one disc and had no issues with redumper or DIC, but this probably should be tested with aaru by someone who knows what they're doing.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/589 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 10/26/2023 **Status:** ✅ Merged **Merged:** 10/26/2023 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `relative-path` --- ### 📝 Commits (1) - [`c1d566a`](https://github.com/SabreTools/MPF/commit/c1d566a0bfd8f10106d549cfd51f6f8040dd52f7) Use relative path internally ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `MPF.Core/DumpEnvironment.cs` (+2 -2) 📝 `MPF.Core/UI/ViewModels/MainViewModel.cs` (+1 -1) </details> ### 📄 Description Set the getFullPath flags to false in the 3 places in MPF that still use full paths (except in MPF.Test). I have tested this for one disc and had no issues with redumper or DIC, but this probably should be tested with aaru by someone who knows what they're doing. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:25:06 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1049