[PR #585] [MERGED] Set UDF CD threshold at 800MB #1051

New Issue

Closed

opened 2026-01-29 16:25:06 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:25:06 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/585
Author: @Deterous
Created: 10/20/2023
Status: ✅ Merged
Merged: 10/20/2023
Merged by: @mnadareski

Base: master ← Head: udf-cd-size

---

📝 Commits (2)

• daccebd Set UDF CD threshold at 800MB
• 1561b23 Condense DriveFormat checks

📊 Changes

1 file changed (+2 additions, -6 deletions)

View changed files

📝 MPF.Core/Data/Drive.cs (+2 -6)

📄 Description

Currently, optical media type detection for UDF filesystems is set to DVDs if the size is at least 400MB.

Based on the PC CDs and DVDs in redump, the false positive rate for DVD detection when using a threshold of 800 MB is less than 3%, with an optimal threshold for CD and DVD false detection rate at approx 830MB. However, I think it is best that MPF keep the threshold at 800 MB as CDs greater than 800 MB in size are technically not following the CD-ROM standard.

I have also changed it slightly to set discs with exactly 800 MB as CDs.

Cumulative distributions for PC DVDs (in red) and PC CDs (in blue) with regards to size, where the crossover represents the point with the "lowest false detection rate":

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/585 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 10/20/2023 **Status:** ✅ Merged **Merged:** 10/20/2023 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `udf-cd-size` --- ### 📝 Commits (2) - [`daccebd`](https://github.com/SabreTools/MPF/commit/daccebdc51fd56829de7aafeab5f6c84ea47c146) Set UDF CD threshold at 800MB - [`1561b23`](https://github.com/SabreTools/MPF/commit/1561b23c9d58471ca15a951dbbacb0333c1fdca7) Condense DriveFormat checks ### 📊 Changes **1 file changed** (+2 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `MPF.Core/Data/Drive.cs` (+2 -6) </details> ### 📄 Description Currently, optical media type detection for UDF filesystems is set to DVDs if the size is at least 400MB. Based on the PC CDs and DVDs in redump, the false positive rate for DVD detection when using a threshold of 800 MB is less than 3%, with an optimal threshold for CD and DVD false detection rate at approx 830MB. However, I think it is best that MPF keep the threshold at 800 MB as CDs greater than 800 MB in size are technically not following the CD-ROM standard. I have also changed it slightly to set discs with exactly 800 MB as CDs. Cumulative distributions for PC DVDs (in red) and PC CDs (in blue) with regards to size, where the crossover represents the point with the "lowest false detection rate":   --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:25:06 +00:00

claunia closed this issue 2026-01-29 16:25:06 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1051