SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-04 05:35:52 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #627] [MERGED] Retrieve volume label from logs #1067

New Issue
Open
opened 2026-01-29 16:25:12 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:25:12 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/627
Author: @Deterous
Created: 1/15/2024
Status: ✅ Merged
Merged: 1/16/2024
Merged by: @mnadareski

Base: master ← Head: det-patch-6

📝 Commits (6)

📊 Changes

6 files changed (+231 additions, -21 deletions)

View changed files

📝 CHANGELIST.md (+1 -0)
📝 MPF.Core/Data/Drive.cs (+14 -14)
📝 MPF.Core/Modules/BaseParameters.cs (+5 -0)
📝 MPF.Core/Modules/DiscImageCreator/Parameters.cs (+87 -0)
📝 MPF.Core/Modules/Redumper/Parameters.cs (+62 -4)
📝 MPF.Core/SubmissionInfoTool.cs (+62 -3)

📄 Description

  • Parses ISO label from Redumper logs
  • Parses ISO/Joliet/UDF label from DIC logs
  • Adds formatted list of labels from logs to [T:VOL] tag, on top of whatever Windows sees
  • Adds a Dictionary<string, List<string>>? VolumeLabels field to BaseParameters
  • Makes Drive.GetRedumpSystemFromVolumeLabel a static method

Attempts to fix #579

Perhaps needs more testing, and figuring out where in Aaru logs the volume label is.
Note: With this change, Aaru still outputs "[T:VOL] %label%" exactly as prior functionality.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/627 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 1/15/2024 **Status:** ✅ Merged **Merged:** 1/16/2024 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `det-patch-6` --- ### 📝 Commits (6) - [`9ede05f`](https://github.com/SabreTools/MPF/commit/9ede05fb6e873ff44c5089b97e107af41ec971c0) Retrieve volume label from DIC and redumper logs - [`37f6680`](https://github.com/SabreTools/MPF/commit/37f6680f1265766153f69f14d5b5f0b5a15d0f38) Fix logic - [`72341e2`](https://github.com/SabreTools/MPF/commit/72341e25ba5c662abd693f35cbd3a26fa4b9864c) Remove unnecessary using - [`72c6b5d`](https://github.com/SabreTools/MPF/commit/72c6b5d6d399368665dba3be1d824371c5e61025) Update changelog - [`d2886b5`](https://github.com/SabreTools/MPF/commit/d2886b526987321df325f7a6df526b627c001541) Sanitise label somewhat - [`40e5065`](https://github.com/SabreTools/MPF/commit/40e5065e017e3f030ce1a026e7346615c5c1d8cf) Refactor ### 📊 Changes **6 files changed** (+231 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+1 -0) 📝 `MPF.Core/Data/Drive.cs` (+14 -14) 📝 `MPF.Core/Modules/BaseParameters.cs` (+5 -0) 📝 `MPF.Core/Modules/DiscImageCreator/Parameters.cs` (+87 -0) 📝 `MPF.Core/Modules/Redumper/Parameters.cs` (+62 -4) 📝 `MPF.Core/SubmissionInfoTool.cs` (+62 -3) </details> ### 📄 Description - Parses ISO label from Redumper logs - Parses ISO/Joliet/UDF label from DIC logs - Adds formatted list of labels from logs to [T:VOL] tag, on top of whatever Windows sees - Adds a `Dictionary<string, List<string>>? VolumeLabels` field to BaseParameters - Makes `Drive.GetRedumpSystemFromVolumeLabel` a static method Attempts to fix #579 Perhaps needs more testing, and figuring out where in Aaru logs the volume label is. Note: With this change, Aaru still outputs "[T:VOL] %label%" exactly as prior functionality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:25:12 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#1067
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?