[PR #628] [MERGED] Correct missing space in PVD #1072

Closed
opened 2026-01-29 16:25:12 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/628
Author: @fuzz6001
Created: 1/16/2024
Status: Merged
Merged: 1/16/2024
Merged by: @mnadareski

Base: masterHead: fix-missing-character-in-pvd


📝 Commits (2)

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 CHANGELIST.md (+1 -0)
📝 MPF.Core/Modules/Redumper/Parameters.cs (+2 -2)

📄 Description

In rare cases, if there is a space at the end of each line in the PVD output, it will be missing.
screenshot 1705405198

Therefore, remove Trim.
screenshot 1705405411


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/628 **Author:** [@fuzz6001](https://github.com/fuzz6001) **Created:** 1/16/2024 **Status:** ✅ Merged **Merged:** 1/16/2024 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `fix-missing-character-in-pvd` --- ### 📝 Commits (2) - [`e371094`](https://github.com/SabreTools/MPF/commit/e371094ed7635d79c0f40089d132bff1466465f3) Remove trim - [`5a892d7`](https://github.com/SabreTools/MPF/commit/5a892d747a8c7a613f641d27bb32129957e14e5e) Update changelist ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+1 -0) 📝 `MPF.Core/Modules/Redumper/Parameters.cs` (+2 -2) </details> ### 📄 Description In rare cases, if there is a space at the end of each line in the PVD output, it will be missing. ![screenshot 1705405198](https://github.com/SabreTools/MPF/assets/2080945/a442eee5-d09f-47d2-af0f-d49655430ef6) Therefore, remove Trim. ![screenshot 1705405411](https://github.com/SabreTools/MPF/assets/2080945/4dc87f8e-2786-4b2d-a7c1-65d7b7df3b0b) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:25:12 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#1072