[PR #645] [MERGED] Fix compiler warning #1080

New Issue

Open

opened 2026-01-29 16:25:16 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:25:16 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/645
Author: @Deterous
Created: 2/6/2024
Status: ✅ Merged
Merged: 2/6/2024
Merged by: @mnadareski

Base: master ← Head: compile-warning

---

📝 Commits (2)

• 29f39bb Fix compiler warning about PresentationFramework.Aero2
• 50d23c1 Update changelog

📊 Changes

2 files changed (+1 additions, -3 deletions)

View changed files

📝 CHANGELIST.md (+1 -0)
📝 MPF/MPF.csproj (+0 -3)

📄 Description

Compiler (even Appveyor) currently gives this warning for .NET Core builds:
warning MSB3243: No way to resolve conflict between "PresentationFramework.Aero2, Version=6.0.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35" and "PresentationFramework.Aero2". Choosing "PresentationFramework.Aero2, Version=6.0.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35"

I'm unsure what is already implicitly pulling PresentationFramework.Aero2, but by removing the redundant reference, this warning goes away (check the appveyor compiler messages for this build).

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/645 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 2/6/2024 **Status:** ✅ Merged **Merged:** 2/6/2024 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `compile-warning` --- ### 📝 Commits (2) - [`29f39bb`](https://github.com/SabreTools/MPF/commit/29f39bb1b0d0ac5b4c0bc1f5cbcbd63891f3c778) Fix compiler warning about PresentationFramework.Aero2 - [`50d23c1`](https://github.com/SabreTools/MPF/commit/50d23c17a58d421fa3068ec17d03dd59c6f04e52) Update changelog ### 📊 Changes **2 files changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+1 -0) 📝 `MPF/MPF.csproj` (+0 -3) </details> ### 📄 Description Compiler (even [Appveyor](https://ci.appveyor.com/project/mnadareski/mpf/builds/49110150)) currently gives this warning for .NET Core builds: `warning MSB3243: No way to resolve conflict between "PresentationFramework.Aero2, Version=6.0.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35" and "PresentationFramework.Aero2". Choosing "PresentationFramework.Aero2, Version=6.0.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35" ` I'm unsure what is already implicitly pulling PresentationFramework.Aero2, but by removing the redundant reference, this warning goes away (check the [appveyor compiler messages for this build](https://ci.appveyor.com/project/mnadareski/mpf/builds/49123283)). --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:25:16 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1080