[PR #649] [MERGED] Fix DIC log parsing for SS version #1085

New Issue

Closed

opened 2026-01-29 16:25:17 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:25:17 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/649
Author: @Deterous
Created: 2/12/2024
Status: ✅ Merged
Merged: 2/12/2024
Merged by: @mnadareski

Base: master ← Head: ss-version

---

📝 Commits (1)

• b8f84e0 Fix DIC log parsing for SS version

📊 Changes

2 files changed (+15 additions, -4 deletions)

View changed files

📝 CHANGELIST.md (+1 -0)
📝 MPF.Core/Modules/DiscImageCreator/Parameters.cs (+14 -4)

📄 Description

MPF currently parses

Version of challenge table: 02

in DIC logs as the SS (security sector) version.

This is actually DIC's way of saying the XGD version (1 = Xbox, 2 = Xbox360): 31b4d32082/DiscImageCreator/execScsiCmdforDVD.cpp (L1959)

Instead, the SS version for all Kreon dumps using DIC is 1. Useful SSv2 data is only obtainable by 0800 drives, which are not supported by DIC (or any of MPF's current dumping programs).

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/649 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 2/12/2024 **Status:** ✅ Merged **Merged:** 2/12/2024 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `ss-version` --- ### 📝 Commits (1) - [`b8f84e0`](https://github.com/SabreTools/MPF/commit/b8f84e0f599a22cff6e14f5c8c57e643722d9f60) Fix DIC log parsing for SS version ### 📊 Changes **2 files changed** (+15 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+1 -0) 📝 `MPF.Core/Modules/DiscImageCreator/Parameters.cs` (+14 -4) </details> ### 📄 Description MPF currently parses > Version of challenge table: 02 in DIC logs as the SS (security sector) version. This is actually DIC's way of saying the XGD version (1 = Xbox, 2 = Xbox360): https://github.com/saramibreak/DiscImageCreator/blob/31b4d32082a1ec00cf69e6edb369f982001ac807/DiscImageCreator/execScsiCmdforDVD.cpp#L1959 Instead, the SS version for all Kreon dumps using DIC is 1. Useful SSv2 data is only obtainable by 0800 drives, which are not supported by DIC (or any of MPF's current dumping programs). --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:25:17 +00:00

claunia closed this issue 2026-01-29 16:25:17 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1085