[PR #654] [MERGED] Hide unavailable dumping programs #1087

New Issue

claunia · 2026-01-29T16:25:19Z

claunia commented

2026-01-29 16:25:19 +00:00

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/654
Author: @Deterous
Created: 2/21/2024
Status: ✅ Merged
Merged: 2/21/2024
Merged by: @mnadareski

Base: master ← Head: hide-internal-programs

📝 Commits (1)

bd5f55d Hide unavailable dumping programs

📊 Changes

3 files changed (+57 additions, -11 deletions)

View changed files

📝 CHANGELIST.md (+1 -0)
📝 MPF.Core/DumpEnvironment.cs (+12 -3)
📝 MPF.Core/UI/ViewModels/MainViewModel.cs (+44 -8)

📄 Description

If a dumping program has been deleted from the Programs/ folder, or it was not bundled with an MPF build, remove it from the list of selectable dumping programs on the main window.
If no programs are found, warn the user.

This is an attempt at a soft solution for #527 whereby support for dumping with DIC remains intact, but at some point in the future, MPF releases can be packaged without bundled DIC, and users who wish to dump with DIC will just need to add it to the Programs/ folder.

Perhaps something similar needs adding to the Default Dumping Program dropdown in the Options window, but for now it works fine if the default program is not available. Having a default program that doesn't exist (yet) could be a desired option anyway?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/654 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 2/21/2024 **Status:** ✅ Merged **Merged:** 2/21/2024 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `hide-internal-programs` --- ### 📝 Commits (1) - [`bd5f55d`](https://github.com/SabreTools/MPF/commit/bd5f55dc4bab9f0776dcf5f07fcf37d022b850dc) Hide unavailable dumping programs ### 📊 Changes **3 files changed** (+57 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+1 -0) 📝 `MPF.Core/DumpEnvironment.cs` (+12 -3) 📝 `MPF.Core/UI/ViewModels/MainViewModel.cs` (+44 -8) </details> ### 📄 Description If a dumping program has been deleted from the `Programs/` folder, or it was not bundled with an MPF build, remove it from the list of selectable dumping programs on the main window. If no programs are found, warn the user. This is an attempt at a soft solution for #527 whereby support for dumping with DIC remains intact, but at some point in the future, MPF releases can be packaged without bundled DIC, and users who wish to dump with DIC will just need to add it to the `Programs/` folder. Perhaps something similar needs adding to the Default Dumping Program dropdown in the Options window, but for now it works fine if the default program is not available. Having a default program that doesn't exist (yet) could be a desired option anyway? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:25:19 +00:00

claunia closed this issue

2026-01-29 16:25:19 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1087