SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-11 21:29:24 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #655] [MERGED] Opt-in automatic IRD creation after PS3 dump #1088

New Issue
Closed
opened 2026-01-29 16:25:19 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:25:19 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/655
Author: @Deterous
Created: 2/22/2024
Status: ✅ Merged
Merged: 2/23/2024
Merged by: @mnadareski

Base: master ← Head: ird-after-dump

📝 Commits (4)

  • b631bb3 Opt-in automatic IRD creation after PS3 dump
  • 4f8cba1 Add tabs before an endregion
  • 3dc26f8 Prevent double checking for existing files
  • 1200af4 Spin off IRD creation into new thread

📊 Changes

9 files changed (+504 additions, -362 deletions)

View changed files

📝 CHANGELIST.md (+1 -0)
📝 MPF.Core/Data/Options.cs (+14 -0)
📝 MPF.Core/DumpEnvironment.cs (+13 -0)
📝 MPF.Core/InfoTool.cs (+52 -0)
📝 MPF.Core/UI/ViewModels/CreateIRDViewModel.cs (+9 -321)
📝 MPF.Core/UI/ViewModels/MainViewModel.cs (+42 -40)
📝 MPF.Core/UI/ViewModels/OptionsViewModel.cs (+13 -0)
📝 MPF.Core/Utilities/Tools.cs (+354 -0)
📝 MPF.UI.Core/Windows/OptionsWindow.xaml (+6 -1)

📄 Description

Adds yet another checkbox in the Dumping options menu to create an IRD file following a PS3 BD-ROM dump.
This is not by default as it can take up to 10min for a large ISO on an HDD.
The IRD creation will occur following the disc information window, it is the last thing to happen after a PS3 dump. This ensures that if a user is not patient and force-closes MPF, then the logs for that dump have already been zipped, etc.

It will also ONLY occur if the Disc Key field was filled in on the Disc Information Window.
Pulling the key from redump is currently not implemented - perhaps this needs to occur by default if a match is found?

Fixes #323

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/655 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 2/22/2024 **Status:** ✅ Merged **Merged:** 2/23/2024 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `ird-after-dump` --- ### 📝 Commits (4) - [`b631bb3`](https://github.com/SabreTools/MPF/commit/b631bb3aa352b099b9dfca8f522e7d7c5845029d) Opt-in automatic IRD creation after PS3 dump - [`4f8cba1`](https://github.com/SabreTools/MPF/commit/4f8cba1e5ba96d3493003bc6aa0206ac78aec1aa) Add tabs before an endregion - [`3dc26f8`](https://github.com/SabreTools/MPF/commit/3dc26f819d64a8a47fe67dca67463de3a8a85d97) Prevent double checking for existing files - [`1200af4`](https://github.com/SabreTools/MPF/commit/1200af4f7e8a2a2d58f4ca327f08b86390bd2df7) Spin off IRD creation into new thread ### 📊 Changes **9 files changed** (+504 additions, -362 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+1 -0) 📝 `MPF.Core/Data/Options.cs` (+14 -0) 📝 `MPF.Core/DumpEnvironment.cs` (+13 -0) 📝 `MPF.Core/InfoTool.cs` (+52 -0) 📝 `MPF.Core/UI/ViewModels/CreateIRDViewModel.cs` (+9 -321) 📝 `MPF.Core/UI/ViewModels/MainViewModel.cs` (+42 -40) 📝 `MPF.Core/UI/ViewModels/OptionsViewModel.cs` (+13 -0) 📝 `MPF.Core/Utilities/Tools.cs` (+354 -0) 📝 `MPF.UI.Core/Windows/OptionsWindow.xaml` (+6 -1) </details> ### 📄 Description Adds yet another checkbox in the Dumping options menu to create an IRD file following a PS3 BD-ROM dump. This is not by default as it can take up to 10min for a large ISO on an HDD. The IRD creation will occur following the disc information window, it is the last thing to happen after a PS3 dump. This ensures that if a user is not patient and force-closes MPF, then the logs for that dump have already been zipped, etc. It will also ONLY occur if the Disc Key field was filled in on the Disc Information Window. Pulling the key from redump is currently not implemented - perhaps this needs to occur by default if a match is found? Fixes #323 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:25:19 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#1088
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?