SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #685] [MERGED] Fix CleanRip hash output for Check #1108

New Issue
Closed
opened 2026-01-29 16:25:26 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:25:26 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/685
Author: @Deterous
Created: 4/5/2024
Status: ✅ Merged
Merged: 4/5/2024
Merged by: @mnadareski

Base: master ← Head: fix-cleanrip

📝 Commits (5)

  • dd32c3e ClrMamePro format is for CDs, dont assume hashes are in CleanRip logs
  • da364ec Rename folder
  • b5eef09 Rename folder again
  • 57d998f Update changelog
  • c660a75 Don't trust cleanrip log hashes if any are missing

📊 Changes

2 files changed (+16 additions, -2 deletions)

View changed files

📝 CHANGELIST.md (+1 -0)
📝 MPF.Core/Modules/CleanRip/Parameters.cs (+15 -2)

📄 Description

  • Only generates ClrMamePro datafile if the mediatype is CDROM
  • Deals with case when CleanRip log doesn't have hashes
  • Bonus: renames the CleanRip file :)

Should the ISO be hashed regardless of presence of hash in the CleanRip log? (to double check)
What should happen if the hash of the ISO is mismatched with the log?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/685 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 4/5/2024 **Status:** ✅ Merged **Merged:** 4/5/2024 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `fix-cleanrip` --- ### 📝 Commits (5) - [`dd32c3e`](https://github.com/SabreTools/MPF/commit/dd32c3ee5e7ffdc7663915b5c3e4e0aa158f89e0) ClrMamePro format is for CDs, dont assume hashes are in CleanRip logs - [`da364ec`](https://github.com/SabreTools/MPF/commit/da364ec5ddb462dfcff748de96bd6066a0369a02) Rename folder - [`b5eef09`](https://github.com/SabreTools/MPF/commit/b5eef09c43f1008d7057c41273ad0fb23e06e769) Rename folder again - [`57d998f`](https://github.com/SabreTools/MPF/commit/57d998f09ddad22ff1786f73122302d91fa823fd) Update changelog - [`c660a75`](https://github.com/SabreTools/MPF/commit/c660a7526d67555a1b2d1486ddcd4075806ef302) Don't trust cleanrip log hashes if any are missing ### 📊 Changes **2 files changed** (+16 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+1 -0) 📝 `MPF.Core/Modules/CleanRip/Parameters.cs` (+15 -2) </details> ### 📄 Description - Only generates ClrMamePro datafile if the mediatype is CDROM - Deals with case when CleanRip log doesn't have hashes - Bonus: renames the CleanRip file :) Should the ISO be hashed regardless of presence of hash in the CleanRip log? (to double check) What should happen if the hash of the ISO is mismatched with the log? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:25:26 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#1108
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?