[PR #691] [MERGED] Custom non-redump Redumper options #1111

New Issue

Closed

opened 2026-01-29 16:25:27 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:25:27 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/691
Author: @Deterous
Created: 4/16/2024
Status: ✅ Merged
Merged: 4/16/2024
Merged by: @mnadareski

Base: master ← Head: mpf-rd-opts

---

📝 Commits (3)

• 6b1d9df Gate advanced Redumper options in UI, add read method + sector order
• a2e56cc Update changelog
• 79d9756 Fixed-width text/combo boxes

📊 Changes

9 files changed (+238 additions, -22 deletions)

View changed files

📝 CHANGELIST.md (+1 -0)
📝 MPF.Core/Converters/EnumConverter.cs (+88 -1)
📝 MPF.Core/Data/Enumerations.cs (+25 -0)
📝 MPF.Core/Data/Options.cs (+36 -4)
📝 MPF.Core/Modules/Redumper/Parameters.cs (+7 -2)
📝 MPF.Core/UI/ViewModels/OptionsViewModel.cs (+40 -1)
📝 MPF.UI.Core/ElementConverter.cs (+4 -0)
📝 MPF.UI.Core/Windows/OptionsWindow.xaml (+25 -13)
📝 MPF.UI.Core/Windows/OptionsWindow.xaml.cs (+12 -1)

📄 Description

Currently, MPF UI options allows for Redumper BE_CDDA mode and GENERIC drive type.
These are somewhat arbitrary (e.g. why not also allow BE mode, or other drive types) and more importantly can misinform users who may set these options without knowing that they are not supported for redump submission.

This PR gates GENERIC drive mode behind a new "Non-Redump Mode", as well as extends read method beyond just BE_CDDA, and adds a new sector order option (Fixes #690 )

Preview:

Checking non-redump options shows a warning:

The advanced Redumper options can now be set.

Unchecking Non-Redump Options resets the three options back to their defaults.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/691 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 4/16/2024 **Status:** ✅ Merged **Merged:** 4/16/2024 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `mpf-rd-opts` --- ### 📝 Commits (3) - [`6b1d9df`](https://github.com/SabreTools/MPF/commit/6b1d9dff7013eba70a0ed03a87bf874db54fe7f9) Gate advanced Redumper options in UI, add read method + sector order - [`a2e56cc`](https://github.com/SabreTools/MPF/commit/a2e56ccc07bafb1b3353be3fbffbf7b0498403be) Update changelog - [`79d9756`](https://github.com/SabreTools/MPF/commit/79d975625175948fedf6d203d88a85d6924c2917) Fixed-width text/combo boxes ### 📊 Changes **9 files changed** (+238 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+1 -0) 📝 `MPF.Core/Converters/EnumConverter.cs` (+88 -1) 📝 `MPF.Core/Data/Enumerations.cs` (+25 -0) 📝 `MPF.Core/Data/Options.cs` (+36 -4) 📝 `MPF.Core/Modules/Redumper/Parameters.cs` (+7 -2) 📝 `MPF.Core/UI/ViewModels/OptionsViewModel.cs` (+40 -1) 📝 `MPF.UI.Core/ElementConverter.cs` (+4 -0) 📝 `MPF.UI.Core/Windows/OptionsWindow.xaml` (+25 -13) 📝 `MPF.UI.Core/Windows/OptionsWindow.xaml.cs` (+12 -1) </details> ### 📄 Description Currently, MPF UI options allows for Redumper BE_CDDA mode and GENERIC drive type. These are somewhat arbitrary (e.g. why not also allow BE mode, or other drive types) and more importantly can misinform users who may set these options without knowing that they are not supported for redump submission. This PR gates GENERIC drive mode behind a new "Non-Redump Mode", as well as extends read method beyond just BE_CDDA, and adds a new sector order option (Fixes #690 ) Preview:  Checking non-redump options shows a warning:  The advanced Redumper options can now be set.  Unchecking Non-Redump Options resets the three options back to their defaults. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:25:27 +00:00

claunia closed this issue 2026-01-29 16:25:27 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.7.1

3.7.0

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1111