[PR #709] [CLOSED] Fix incorrect matching disc found #1123

New Issue

Open

opened 2026-01-29 16:25:32 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:25:32 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/709
Author: @Deterous
Created: 6/7/2024
Status: ❌ Closed

Base: master ← Head: master

---

📝 Commits (2)

• a7735b7 Fix incorrect matching disc found
• 3b1b35d semicolon

📊 Changes

2 files changed (+4 additions, -3 deletions)

View changed files

📝 CHANGELIST.md (+1 -0)
📝 MPF.Frontend/Tools/SubmissionGenerator.cs (+3 -3)

📄 Description

Ensures that a disc is not detected as in redump if all tracks are in redump but they're not all the same disc ID.

Fixes #708

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/709 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 6/7/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`a7735b7`](https://github.com/SabreTools/MPF/commit/a7735b7ecff9724c218d3f416409604e5b22ca88) Fix incorrect matching disc found - [`3b1b35d`](https://github.com/SabreTools/MPF/commit/3b1b35d519449d0ddb118a5709677dc82b28537a) semicolon ### 📊 Changes **2 files changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+1 -0) 📝 `MPF.Frontend/Tools/SubmissionGenerator.cs` (+3 -3) </details> ### 📄 Description Ensures that a disc is not detected as in redump if all tracks are in redump but they're not all the same disc ID. Fixes #708 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:25:32 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1123