[PR #724] [MERGED] Fix logic for deducing region from PlayStation ISN #1133

New Issue

claunia · 2026-01-29T16:25:36Z

claunia commented

2026-01-29 16:25:36 +00:00

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/724
Author: @JohnVeness
Created: 7/13/2024
Status: ✅ Merged
Merged: 7/16/2024
Merged by: @mnadareski

Base: master ← Head: region

📝 Commits (9)

8c9b519 Deduce PS2 region from Redumper serial
275809e Fix logic for deducing region from PlayStation ISN
4ef6d6a Fix logic again
2de9fed Fix logic again again
b12c9d8 Merge branch 'region' of github.com:JohnVeness/MPF into region
ee3036a Fix this too
976b34a Undo Redumper change
976c726 Reorder functions
d13a3c3 Fix OR/AND logic

📊 Changes

3 files changed (+93 additions, -92 deletions)

View changed files

📝 MPF.Frontend/Drive.cs (+2 -86)
📝 MPF.Frontend/Tools/SubmissionGenerator.cs (+6 -6)
📝 MPF.Processors/ProcessingTool.cs (+85 -0)

📄 Description

An attempt to fix #722. Please note that I am a complete C# amateur and don't know whether this is the best implementation! And I haven't added it for PS1.

I'm a bit confused about line 8c9b519148/MPF.Frontend/Tools/SubmissionGenerator.cs (L837) which doesn't seem to get executed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/724 **Author:** [@JohnVeness](https://github.com/JohnVeness) **Created:** 7/13/2024 **Status:** ✅ Merged **Merged:** 7/16/2024 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `region` --- ### 📝 Commits (9) - [`8c9b519`](https://github.com/SabreTools/MPF/commit/8c9b51914850f583cd70576f500673427d9f4a78) Deduce PS2 region from Redumper serial - [`275809e`](https://github.com/SabreTools/MPF/commit/275809e93e9881a81a311e679f7a3e0a70ddd182) Fix logic for deducing region from PlayStation ISN - [`4ef6d6a`](https://github.com/SabreTools/MPF/commit/4ef6d6a6b3a9659b078ba44c912772ff262f15fb) Fix logic again - [`2de9fed`](https://github.com/SabreTools/MPF/commit/2de9fed56850652780f7ba8b2b22893dc4779a0c) Fix logic again again - [`b12c9d8`](https://github.com/SabreTools/MPF/commit/b12c9d8c9090b58dcbff117b82de373dede048d8) Merge branch 'region' of github.com:JohnVeness/MPF into region - [`ee3036a`](https://github.com/SabreTools/MPF/commit/ee3036a57c43476fd62199d931520fddbebb8282) Fix this too - [`976b34a`](https://github.com/SabreTools/MPF/commit/976b34a1f6b8de4d1e01a96a5ccc008905e04ac9) Undo Redumper change - [`976c726`](https://github.com/SabreTools/MPF/commit/976c726fcc6e59bba47eda6f4d709a8e58d0b177) Reorder functions - [`d13a3c3`](https://github.com/SabreTools/MPF/commit/d13a3c3419ea2e53633567a025e86ed19da10dcf) Fix OR/AND logic ### 📊 Changes **3 files changed** (+93 additions, -92 deletions) <details> <summary>View changed files</summary> 📝 `MPF.Frontend/Drive.cs` (+2 -86) 📝 `MPF.Frontend/Tools/SubmissionGenerator.cs` (+6 -6) 📝 `MPF.Processors/ProcessingTool.cs` (+85 -0) </details> ### 📄 Description An attempt to fix #722. Please note that I am a complete C# amateur and don't know whether this is the best implementation! And I haven't added it for PS1. I'm a bit confused about line https://github.com/JohnVeness/MPF/blob/8c9b51914850f583cd70576f500673427d9f4a78/MPF.Frontend/Tools/SubmissionGenerator.cs#L837 which doesn't seem to get executed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:25:37 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1133