[PR #837] [MERGED] Change redumper default commands #1187

New Issue

Open

opened 2026-01-29 16:25:55 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:25:55 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/837
Author: @Deterous
Created: 4/17/2025
Status: ✅ Merged
Merged: 4/18/2025
Merged by: @mnadareski

Base: master ← Head: master

---

📝 Commits (10+)

• 00bf39d Allow "0" drive speed
• 08b2ca7 Default speed 1 for unknown system
• 46e7bba default speed of 1
• 8f99fe9 No skeleton
• 8e41803 No base command by default
• fce059d Change speed in redumper tests
• e3d907d Dump no longer dumping command
• e25b7e5 Re-allow quick exiting always
• a371228 No base command is a dumping command
• 0f47e88 Only one mode command per redumper call

📊 Changes

4 files changed (+94 additions, -85 deletions)

View changed files

📝 MPF.ExecutionContexts.Test/RedumperTests.cs (+59 -59)
📝 MPF.ExecutionContexts/Redumper/ExecutionContext.cs (+23 -23)
📝 MPF.Frontend/InterfaceConstants.cs (+2 -2)
📝 MPF.Frontend/ViewModels/MainViewModel.cs (+10 -1)

📄 Description

Redumper now only allows a single mode command. Default no base command is used for redumper dumps. The implication is of removing skeleton from CD dumps. Also, drive speed is no longer a required parameter.

By setting drive speed to "0", MPF will now not add a speed parameter for redumper dumps. This results in a max speed dump.
This matches DIC where "0" means max speed.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/837 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 4/17/2025 **Status:** ✅ Merged **Merged:** 4/18/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`00bf39d`](https://github.com/SabreTools/MPF/commit/00bf39d73d6454dee0bc447b945d7f4fca3442ea) Allow "0" drive speed - [`08b2ca7`](https://github.com/SabreTools/MPF/commit/08b2ca71cb121ee18b9852272e3722ab83d855e0) Default speed 1 for unknown system - [`46e7bba`](https://github.com/SabreTools/MPF/commit/46e7bba32bf557cbeeec6817003e571a760a16c1) default speed of 1 - [`8f99fe9`](https://github.com/SabreTools/MPF/commit/8f99fe9e678465f2cf03b68f4476c6fcd1e25f36) No skeleton - [`8e41803`](https://github.com/SabreTools/MPF/commit/8e418034afc0914ac95fa99054baca2afc8b1012) No base command by default - [`fce059d`](https://github.com/SabreTools/MPF/commit/fce059d4a75e3d8553888f342dd45804353de85a) Change speed in redumper tests - [`e3d907d`](https://github.com/SabreTools/MPF/commit/e3d907d89af583dd233d55f2f17ca758b52c85b9) Dump no longer dumping command - [`e25b7e5`](https://github.com/SabreTools/MPF/commit/e25b7e5af26c7183441b961ce39c5a00b4107641) Re-allow quick exiting always - [`a371228`](https://github.com/SabreTools/MPF/commit/a371228b15ec721d71663b89b09c845cec063812) No base command is a dumping command - [`0f47e88`](https://github.com/SabreTools/MPF/commit/0f47e88730c156db440122e5cd02e5f27f160251) Only one mode command per redumper call ### 📊 Changes **4 files changed** (+94 additions, -85 deletions) <details> <summary>View changed files</summary> 📝 `MPF.ExecutionContexts.Test/RedumperTests.cs` (+59 -59) 📝 `MPF.ExecutionContexts/Redumper/ExecutionContext.cs` (+23 -23) 📝 `MPF.Frontend/InterfaceConstants.cs` (+2 -2) 📝 `MPF.Frontend/ViewModels/MainViewModel.cs` (+10 -1) </details> ### 📄 Description Redumper now only allows a single mode command. Default no base command is used for redumper dumps. The implication is of removing skeleton from CD dumps. Also, drive speed is no longer a required parameter. By setting drive speed to "0", MPF will now not add a speed parameter for redumper dumps. This results in a max speed dump. This matches DIC where "0" means max speed. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:25:55 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1187