SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-09 21:32:19 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #854] [MERGED] Update redumper, MPF options, SS sanity check #1196

New Issue
Open
opened 2026-01-29 16:25:58 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:25:58 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/854
Author: @Deterous
Created: 5/30/2025
Status: ✅ Merged
Merged: 5/30/2025
Merged by: @mnadareski

Base: master ← Head: master

📝 Commits (10+)

📊 Changes

15 files changed (+289 additions, -155 deletions)

View changed files

📝 CHANGELIST.md (+1 -0)
📝 MPF.ExecutionContexts.Test/RedumperTests.cs (+66 -67)
📝 MPF.ExecutionContexts/Redumper/Enumerations.cs (+17 -2)
📝 MPF.ExecutionContexts/Redumper/ExecutionContext.cs (+42 -23)
📝 MPF.ExecutionContexts/Redumper/FlagStrings.cs (+22 -9)
📝 MPF.ExecutionContexts/Redumper/SettingConstants.cs (+4 -7)
📝 MPF.Frontend.Test/EnumExtensionsTests.cs (+18 -2)
📝 MPF.Frontend/EnumExtensions.cs (+64 -6)
📝 MPF.Frontend/Options.cs (+12 -13)
📝 MPF.Frontend/ViewModels/OptionsViewModel.cs (+17 -2)
📝 MPF.Processors/ProcessingTool.cs (+4 -0)
📝 MPF.UI/ElementConverter.cs (+3 -0)
📝 MPF.UI/Windows/OptionsWindow.xaml (+9 -14)
📝 publish-nix.sh (+5 -5)
📝 publish-win.ps1 (+5 -5)

📄 Description

  • Updates redumper to build 597 (New: Drive detection rework, XGD3 SS repairing)
    • Adds new redumper flags (ListRecommendedDrives, ListAllDrives, Rings)
    • Remove BE_CDDA as a read method
    • Redumper flags reordering
  • Improve redumper options
    • Simplify MPF's retries and plextor leadin retries options
    • Adds a DriveType option to MPF (extends Generic drive option to include PLEXTOR and LG_ASU* types)
  • Extra SS sanity check to prevent bad SS files from being created/hashed (.security file is still kept)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/854 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 5/30/2025 **Status:** ✅ Merged **Merged:** 5/30/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`8da0d48`](https://github.com/SabreTools/MPF/commit/8da0d481d5bd846f117c0ed7ea32cad9ad50318b) Update redumper, add DriveType option - [`2e705ae`](https://github.com/SabreTools/MPF/commit/2e705ae5cff33d8927766ab3ae16c09ed559fa34) Fix typo - [`60f8c82`](https://github.com/SabreTools/MPF/commit/60f8c825dadc1c4ec9e6dc0067e4db127d1ce311) Don't save ss file if invalid SS - [`940d748`](https://github.com/SabreTools/MPF/commit/940d74883c16607fdbd5311245af58d1c97ab0a4) Update changelist - [`c07c1a1`](https://github.com/SabreTools/MPF/commit/c07c1a128c7c1014585490b7754417a4eb36b91d) LongName for DriveType - [`3d98105`](https://github.com/SabreTools/MPF/commit/3d9810589309d3c380facbca356ec1a175fd6884) Fix typo - [`596cf09`](https://github.com/SabreTools/MPF/commit/596cf0925cbf98b7ca2233d8a1c34c3b85089d5d) Fix tests - [`752b15c`](https://github.com/SabreTools/MPF/commit/752b15ca122ea5237522985e837f389b8f19e57b) Redo tests - [`2842366`](https://github.com/SabreTools/MPF/commit/2842366e04674c8854d5fbabc9724a74aaa60efe) Fix test typo - [`87194b4`](https://github.com/SabreTools/MPF/commit/87194b451fa0546b3cebe4afc8c7b091d0430336) Remove additional space from test ### 📊 Changes **15 files changed** (+289 additions, -155 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+1 -0) 📝 `MPF.ExecutionContexts.Test/RedumperTests.cs` (+66 -67) 📝 `MPF.ExecutionContexts/Redumper/Enumerations.cs` (+17 -2) 📝 `MPF.ExecutionContexts/Redumper/ExecutionContext.cs` (+42 -23) 📝 `MPF.ExecutionContexts/Redumper/FlagStrings.cs` (+22 -9) 📝 `MPF.ExecutionContexts/Redumper/SettingConstants.cs` (+4 -7) 📝 `MPF.Frontend.Test/EnumExtensionsTests.cs` (+18 -2) 📝 `MPF.Frontend/EnumExtensions.cs` (+64 -6) 📝 `MPF.Frontend/Options.cs` (+12 -13) 📝 `MPF.Frontend/ViewModels/OptionsViewModel.cs` (+17 -2) 📝 `MPF.Processors/ProcessingTool.cs` (+4 -0) 📝 `MPF.UI/ElementConverter.cs` (+3 -0) 📝 `MPF.UI/Windows/OptionsWindow.xaml` (+9 -14) 📝 `publish-nix.sh` (+5 -5) 📝 `publish-win.ps1` (+5 -5) </details> ### 📄 Description - Updates redumper to build 597 (New: Drive detection rework, XGD3 SS repairing) - Adds new redumper flags (ListRecommendedDrives, ListAllDrives, Rings) - Remove BE_CDDA as a read method - Redumper flags reordering - Improve redumper options - Simplify MPF's retries and plextor leadin retries options - Adds a DriveType option to MPF (extends Generic drive option to include PLEXTOR and LG_ASU* types) - Extra SS sanity check to prevent bad SS files from being created/hashed (.security file is still kept) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:25:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#1196
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?