[PR #856] [CLOSED] Look for dumping programs on $PATH #1198

New Issue

claunia · 2026-01-29T16:25:58Z

claunia commented

2026-01-29 16:25:58 +00:00

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/856
Author: @leo60228
Created: 6/3/2025
Status: ❌ Closed

Base: master ← Head: resolve-binary-path

📝 Commits (1)

86ac79c Look for dumping programs on $PATH

📊 Changes

1 file changed (+21 additions, -3 deletions)

View changed files

📝 MPF.CLI/Program.cs (+21 -3)

📄 Description

This can be more flexible and convenient in certain configurations. For example, on NixOS it isn't unreasonable to want to run MPF in a nix shell with a temporary installation of redumper on $PATH.
I tried to avoid unneeded repetition in the code, which was a bit difficult since a property can't be passed as a ref parameter. I can switch to making ResolveBinary only called as a fallback if that would be preferable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/856 **Author:** [@leo60228](https://github.com/leo60228) **Created:** 6/3/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `resolve-binary-path` --- ### 📝 Commits (1) - [`86ac79c`](https://github.com/SabreTools/MPF/commit/86ac79c81c58a7f50b5515afac3103a730fc0d9a) Look for dumping programs on $PATH ### 📊 Changes **1 file changed** (+21 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `MPF.CLI/Program.cs` (+21 -3) </details> ### 📄 Description This can be more flexible and convenient in certain configurations. For example, on NixOS it isn't unreasonable to want to run MPF in a `nix shell` with a temporary installation of redumper on $PATH. I tried to avoid unneeded repetition in the code, which was a bit difficult since a property can't be passed as a `ref` parameter. I can switch to making `ResolveBinary` only called as a fallback if that would be preferable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:25:58 +00:00

claunia closed this issue

2026-01-29 16:25:58 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1198