mirror of
https://github.com/SabreTools/MPF.git
synced 2026-04-05 22:01:16 +00:00
Improve PS1/PS2 region detection #171
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Landcross on GitHub (Jan 27, 2020).
Originally assigned to: @mnadareski on GitHub.
Recently this issue was incorporated and closed: https://github.com/SabreTools/DICUI/issues/175 with commit
cb39599a46But the logic can be improved. Quite a few serial types are not included, and a bunch of serial types that are included have no reason to be.
It's probably easier to look at the third letter: A = Asia, C = China, E = Europe (any specific region unknown), K = Korea, P = Japan, U = USA. Except when the id starts with a P. Then it's very different, but those are not very common anyway.
pbgp, czp2, hsn and gn can be removed anyway, afaik those are only packaging serials.
@mnadareski commented on GitHub (Jan 27, 2020):
Do you mind clarifying for the
Pcases? Or if you happen to have a link that describes this further I'd appreciate it@Landcross commented on GitHub (Jan 27, 2020):
The P serials can be looked up on Redump, PAPX, PBPX, PCPX, PDPX and PEPX. PAPX and PXPC can somewhat be assumed to be Japanese, but the other ones. I doubt it's worth making a logic for those because it's either guesswork or it won't even barely be used anyway.
@RibShark commented on GitHub (Jan 27, 2020):
Jcan sometimes also be used for Korea (and maybe other asian discs too?)Not really something that can be useful for redump, but 2nd character can be
Cfor Sony published software (occasionallyIin Japan), andLfor 3rd party software. 4th character is usuallySfor most full games,Dfor demos andMfor Japanese/Asian titles that do not use Sony's own distribution network.@mnadareski commented on GitHub (Jan 27, 2020):
Some of that other information may be useful to set the disc type (such as Game or Demo). I'll have to look a little further into the
P*serials before determining if those are worthwhile to add in the check. Definitely have to make sure the first character isSin the serial before trying to get the region from it, at the very least.