mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-07 13:52:12 +00:00
DICUI holds *.sub file handle until exit or another dump start #180
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @superg on GitHub (Feb 18, 2020).
Originally assigned to: @mnadareski on GitHub.
After the dump is successful sometimes I rename / move the directory without closing DICUI and the new versions keeps me from doing that, quite annoying.
@mnadareski commented on GitHub (Feb 18, 2020):
Another fun one I see. Not sure where that would happen, but it's probably in submission gathering. Here's hoping it's an easy catch.
@mnadareski commented on GitHub (Feb 18, 2020):
I'm going to hazard a guess that, in line with the other 5 issues opened, this pertains to PSX games. If that's the case, it's a bug in https://github.com/mnadareski/BurnOutSharp . I'll open the bug there for when I can fix it and link it back here.
@superg commented on GitHub (Feb 18, 2020):
Yeah, it's PSX games but it didn't happen earlier. I recall that some time ago you mentioned that you were looking into libcrypt so I thought you parse *.sub file directly to detect libcrypt.
@mnadareski commented on GitHub (Feb 18, 2020):
Yes, it does parse the
.subfiles directly, but the actual code for detecting LibCrypt lives in the protection detection library. Which is what I mentioned above.@superg commented on GitHub (Feb 18, 2020):
Oh, I didn't realize that BurnOutSharp is also yours, somehow thought it's some external closed source library.
@mnadareski commented on GitHub (Feb 18, 2020):
I just pushed the change to BurnOutSharp that makes the code a little more safe when it comes to checking for LibCrypt. Turns out the 1:1 code port I did before was a bit too simplistic and assumed the original code was reasonable. It wasn't. Once the package gets on NuGet, I'll update DICUI accordingly.