mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-08 05:37:45 +00:00
DICUI doesn't save custom output directory #215
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @TheRogueArchivist on GitHub (Aug 7, 2020).
Originally assigned to: @mnadareski on GitHub.
When trying to change the output directory, DICUI asks if I would like to save these changes. Hitting yes reverts the output directory and other settings such as parameters back to default, prints "Starting dumping process..." to the console, but doesn't actually start the dump. When I only specify custom parameters, hitting yes saves the parameters.
@mnadareski commented on GitHub (Aug 8, 2020):
As discussed on Discord, this is an out-of-order issue caused by user error.
Here is the order of events that happened to trigger the above:
This resulted in the scenario that the new output path from the UI option was overridden by the value in the custom parameters, which was the old value. Due to how the custom parameters can be essentially anything, if they're not saved by the time the dumping program is invoked, it will override anything in the dump environment, regardless of if it was changed from their original values or not. So the value wasn't going to "default", it was just going to the value in the custom parameters.
As a slight remedy to this, the popup that already asks users if they wanted the custom parameters to be applied will also mention that any values in the custom parameters will override settings and profiles selected in the UI. This will hopefully alleviate more of these sort of "bugs" from showing up as this is expected behavior.
@mnadareski commented on GitHub (Sep 9, 2020):
This information has now been reflected into the Wiki here: https://github.com/SabreTools/DICUI/wiki/DICUI