mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-03 21:29:27 +00:00
[Problem] With new DIC 20201101 - read PVD from _mainInfo.txt #251
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Madroms on GitHub (Nov 1, 2020).
Originally assigned to: @mnadareski on GitHub.
With new DIC 20201101, the read of _mainInfo.txt to retrieve PVD is broken.
I only check 1 PS2 CD disc, 1 Saturn disc and 1 DVD VIDEO disc with the new version of DIC. More tests are needed with other discs to validate this piece of code.
On GetPVD function, you may replace most of the code by doing this search:
@Madroms commented on GitHub (Nov 1, 2020):
You can also use the same piece of code for GetSegaHeader (except string pvd... for sure)
@mnadareski commented on GitHub (Nov 1, 2020):
Please attach a copy of the failing
_mainInfo.txtfiles, when you have a chance. I somewhat knew the new DIC's additions would break something.@Madroms commented on GitHub (Nov 2, 2020):
Here are 3 of them.
test_PVD_saturn_disc (1)_mainInfo.txt
test_PVD_DVD_VIDEO_disc (1)_mainInfo.txt
SLPM-60239 (1)_mainInfo.txt
@mnadareski commented on GitHub (Nov 3, 2020):
Since the newest DIC might have some issues, I'm putting this bug on ice for a bit. I will still try to investigate the best way to address this as time goes on, but it's less likely to be soon or before the next release of DICUI.
@mnadareski commented on GitHub (Nov 23, 2020):
This is kinda addressed as of
a183a1ec91but I'm leaving this open just in case the last stable DIC does even something weirder.@Madroms commented on GitHub (Nov 25, 2020):
Great!
I think you also need to modify GetSegaHeader
@mnadareski commented on GitHub (Mar 10, 2021):
Hey @Madroms can you see if this is still an issue with latest WIP builds?
@mnadareski commented on GitHub (Sep 23, 2021):
Closing this as I think this has been fixed and broken multiple times over by this point. It should be in the "fixed" state as of now.