mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-03 21:29:27 +00:00
[Problem] Copy protection gets stuck scanning DLL/MPQ files on Diablo II discs on 1.17+ #261
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @PurpleNekoNova on GitHub (Jan 21, 2021).
Originally assigned to: @mnadareski on GitHub.
Version
What version are you using?
Build
What runtime version are you using?
Describe the issue
Attempting to scan Diablo II discs (http://redump.org/disc/25181/, http://redump.org/disc/25182/, http://redump.org/disc/43323/) for copy protection results in MPF getting "stuck" on either the BINKW32.DLL file (1.17, 1.17.1) or the D2CHAR.MPQ file (1.18, 1.18-480). Drive appears to stop spinning. The same result occurs whether you do a full dump and scan, or if you just do "Scan for protection."
To Reproduce
Steps to reproduce the behavior:
2a. Alternatively do "Scan for protection" on the same discs.
Expected behavior
MPF should scan these discs properly for protection. It works fine on 1.16.1.
Screenshots
@mnadareski commented on GitHub (Jan 21, 2021):
I linked this over to the proper GitHub. I can guarantee that it's only the MPQ files that are causing the issues, as I had to use external library code to scan inside of them and they are slow. I'll try to look into either reasons this is happening or disable MPQ scanning entirely until it can be worked out.
@mnadareski commented on GitHub (Jan 21, 2021):
This has been fixed in BurnOutSharp. I'll close this issue once it gets into the MPF WIP builds.
@mnadareski commented on GitHub (Jan 22, 2021):
Addressed as of
47b5bbe7e7