[Problem] MPF silently closes while scanning for protection #266

New Issue

Closed

opened 2026-01-29 16:13:13 +00:00 by claunia · 4 comments

claunia commented 2026-01-29 16:13:13 +00:00

Owner

Copy Link

Originally created by @Nithanim on GitHub (Jan 23, 2021).

Originally assigned to: @mnadareski on GitHub.

Version
What version are you using?

• Stable release (1.18)
• WIP release (net48 of 47b5bbe7)

Build
What runtime version are you using?

• .NET Framework 4.7.2 running on (Operating System)
• .NET Framework 4.8 running on (Win10)
• .NET Core 3.1 running on (Operating System)

DotNetVersions gave me:

Currently installed "classic" .NET Versions in the system:
2.0.50727.4927 Service Pack 2
3.0.30729.4926 Service Pack 2
3.5.30729.4926 Service Pack 1
4.0.0.0
4.8.04084

Describe the issue
I have successfully dumped multiple discs by now but with one specific disk, MPF just closes while creating the dump. It is related to the "Protection Scan" because when disabled in the Options, the dumping process completes without any issue. I am not sure whose fault (MPF or BurnOutSharp) it is exactly but at least a popup about the problem would be nice instead of a silent crash to desktop.

One tip I got from another issue was to look in the Event Viewer where I found:

Application: MPF.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.FormatException
   at System.Text.StringBuilder.AppendFormatHelper(System.IFormatProvider, System.String, System.ParamsArray)
   at System.String.FormatHelper(System.IFormatProvider, System.String, System.ParamsArray)
   at System.String.Format(System.String, System.Object[])
   at MPF.LoggerViewModel.VerboseLogLn(System.String, System.Object[])
   at MPF.Windows.MainWindow.ProgressUpdated(System.Object, BurnOutSharp.ProtectionProgress)
   at System.Progress`1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].InvokeHandlers(System.Object)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(System.Object)
   at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(System.Object)
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at MS.Internal.CulturePreservingExecutionContext.Run(MS.Internal.CulturePreservingExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
   at MS.Win32.HwndWrapper.WndProc(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(System.Object)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
   at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(System.Windows.Interop.MSG ByRef)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(System.Windows.Threading.DispatcherFrame)
   at System.Windows.Threading.Dispatcher.PushFrame(System.Windows.Threading.DispatcherFrame)
   at System.Windows.Application.RunDispatcher(System.Object)
   at System.Windows.Application.RunInternal(System.Windows.Window)
   at System.Windows.Application.Run(System.Windows.Window)
   at System.Windows.Application.Run()
   at MPF.App.Main()

To Reproduce
Steps to reproduce the behavior:

1. Open MPF
2. Select IBM PC Compatible and CD-ROM
3. Press "Start Dumping"

Expected behavior
Showing at least some error message what happened and not just crashing silently.

Screenshots
None

Additional context
Might be related to #232 because of that issue I now tested specifically with Crysis Warhead and it crashed with exactly the same stacktrace. Although, my game is older and nobody knows it (CD-ROM) and Crysis Warhead is a DVD Game.

Originally created by @Nithanim on GitHub (Jan 23, 2021). Originally assigned to: @mnadareski on GitHub. **Version** What version are you using? - [X] Stable release (1.18) - [X] WIP release ([net48 of 47b5bbe7](https://ci.appveyor.com/project/mnadareski/mpf/builds/37403656/artifacts)) **Build** What runtime version are you using? - [ ] .NET Framework 4.7.2 running on (Operating System) - [X] .NET Framework 4.8 running on (Win10) - [ ] .NET Core 3.1 running on (Operating System) [DotNetVersions](https://github.com/jmalarcon/DotNetVersions) gave me: ``` Currently installed "classic" .NET Versions in the system: 2.0.50727.4927 Service Pack 2 3.0.30729.4926 Service Pack 2 3.5.30729.4926 Service Pack 1 4.0.0.0 4.8.04084 ``` **Describe the issue** I have successfully dumped multiple discs by now but with one specific disk, MPF just closes while creating the dump. It is related to the "Protection Scan" because when disabled in the Options, the dumping process completes without any issue. I am not sure whose fault (MPF or BurnOutSharp) it is exactly but at least a popup about the problem would be nice instead of a silent crash to desktop. One tip I got from another issue was to look in the Event Viewer where I found: ``` Application: MPF.exe Framework Version: v4.0.30319 Description: The process was terminated due to an unhandled exception. Exception Info: System.FormatException at System.Text.StringBuilder.AppendFormatHelper(System.IFormatProvider, System.String, System.ParamsArray) at System.String.FormatHelper(System.IFormatProvider, System.String, System.ParamsArray) at System.String.Format(System.String, System.Object[]) at MPF.LoggerViewModel.VerboseLogLn(System.String, System.Object[]) at MPF.Windows.MainWindow.ProgressUpdated(System.Object, BurnOutSharp.ProtectionProgress) at System.Progress`1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].InvokeHandlers(System.Object) at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32) at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate) at System.Windows.Threading.DispatcherOperation.InvokeImpl() at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(System.Object) at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(System.Object) at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object) at MS.Internal.CulturePreservingExecutionContext.Run(MS.Internal.CulturePreservingExecutionContext, System.Threading.ContextCallback, System.Object) at System.Windows.Threading.DispatcherOperation.Invoke() at System.Windows.Threading.Dispatcher.ProcessQueue() at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef) at MS.Win32.HwndWrapper.WndProc(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef) at MS.Win32.HwndSubclass.DispatcherCallbackOperation(System.Object) at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32) at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate) at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32) at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr) at MS.Win32.UnsafeNativeMethods.DispatchMessage(System.Windows.Interop.MSG ByRef) at System.Windows.Threading.Dispatcher.PushFrameImpl(System.Windows.Threading.DispatcherFrame) at System.Windows.Threading.Dispatcher.PushFrame(System.Windows.Threading.DispatcherFrame) at System.Windows.Application.RunDispatcher(System.Object) at System.Windows.Application.RunInternal(System.Windows.Window) at System.Windows.Application.Run(System.Windows.Window) at System.Windows.Application.Run() at MPF.App.Main() ``` **To Reproduce** Steps to reproduce the behavior: 1. Open MPF 2. Select IBM PC Compatible and CD-ROM 3. Press "Start Dumping" **Expected behavior** Showing at least some error message what happened and not just crashing silently. **Screenshots** None **Additional context** Might be related to #232 because of that issue I now tested specifically with Crysis Warhead and it crashed with exactly the same stacktrace. Although, [my game is older and nobody knows it](https://en.wikipedia.org/wiki/Trade_Empires) (CD-ROM) and [Crysis Warhead](https://en.wikipedia.org/wiki/Crysis_Warhead) is a DVD Game.

claunia added the bug label 2026-01-29 16:13:13 +00:00

claunia closed this issue 2026-01-29 16:13:13 +00:00

claunia commented 2026-01-29 16:13:14 +00:00

Author

Owner

Copy Link

@mnadareski commented on GitHub (Jan 25, 2021):

Looks like a logging issue, so possibly addressed as of 5dd36d7b06
I won't close this until it's confirmed, though. Seems like an easy test to just hit the scan for protection.

@mnadareski commented on GitHub (Jan 25, 2021): Looks like a logging issue, so possibly addressed as of https://github.com/SabreTools/MPF/commit/5dd36d7b06f9142ca3151dbc64f60ba8e401736a I won't close this until it's confirmed, though. Seems like an easy test to just hit the scan for protection.

claunia commented 2026-01-29 16:13:15 +00:00

Author

Owner

Copy Link

@Nithanim commented on GitHub (Jan 25, 2021):

Thank you very much! 2957370f works flawlessly now.

@Nithanim commented on GitHub (Jan 25, 2021): Thank you very much! 2957370f works flawlessly now.

claunia commented 2026-01-29 16:13:16 +00:00

Author

Owner

Copy Link

@mnadareski commented on GitHub (Jan 25, 2021):

Gonna admit, I'm a bit surprised, but I'll take it. Closing this out.

@mnadareski commented on GitHub (Jan 25, 2021): Gonna admit, I'm a bit surprised, but I'll take it. Closing this out.

claunia commented 2026-01-29 16:13:16 +00:00

Author

Owner

Copy Link

@Nithanim commented on GitHub (Jan 25, 2021):

Yeah, I did not know if the library returned something bad or the logging framework had a bug. But with your changes the protection for both my game and Crysis Warhead are reported and the MPF continues to run happily. 👍

@Nithanim commented on GitHub (Jan 25, 2021): Yeah, I did not know if the library returned something bad or the logging framework had a bug. But with your changes the protection for both my game and Crysis Warhead are reported and the MPF continues to run happily. :+1:

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label bug

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#266