SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-07-02 17:24:48 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Problem] Check if sub-program executables exist #267

New Issue
Closed
opened 2026-01-29 16:13:15 +00:00 by claunia · 10 comments
claunia commented 2026-01-29 16:13:15 +00:00
Owner
Copy Link

Originally created by @Nithanim on GitHub (Jan 25, 2021).

Originally assigned to: @mnadareski on GitHub.

Version
What version are you using?

  • Stable release (version here)
  • [X ] WIP release (2957370f net48; basically all starting from d1529f42)

Build
What runtime version are you using?

  • .NET Framework 4.7.2 running on (Operating System)
  • .NET Framework 4.8 running on (Windows 10)
  • .NET Core 3.1 running on (Operating System)

Describe the issue
Before calling one of the included sub-programs (like DiscImageCreator.exe) it should be checked if they exist. Win10 Defender really enjoys deleting the new DiscImageCreator version. The "Start Dumping" button pretty much becomes a no-op then (except for a single log entry) and leaves you completely in the dark on why MPF does not work.

To Reproduce
Steps to reproduce the behavior:

  1. Download a build with DIC version 20210102 on Windows 10
  2. Extract MPF
  3. Completely ignore the Windows notification (like all other useless notifications)
  4. Press "Start Dumping"
  5. Try multiple versions of MPF and wonder for a really long time why it won't do anything
  6. Hate Windows

Expected behavior
An error message (in the logs) that the program executable is not where it should be.

Screenshots
None

Additional context
None

edit: Happy issue 256!

Originally created by @Nithanim on GitHub (Jan 25, 2021). Originally assigned to: @mnadareski on GitHub. **Version** What version are you using? - [ ] Stable release (version here) - [X ] WIP release (2957370f net48; basically all starting from d1529f42) **Build** What runtime version are you using? - [ ] .NET Framework 4.7.2 running on (Operating System) - [X] .NET Framework 4.8 running on (Windows 10) - [ ] .NET Core 3.1 running on (Operating System) **Describe the issue** Before calling one of the included sub-programs (like DiscImageCreator.exe) it should be checked if they exist. Win10 Defender really enjoys deleting the new DiscImageCreator version. The "Start Dumping" button pretty much becomes a no-op then (except for a single log entry) and leaves you completely in the dark on why MPF does not work. **To Reproduce** Steps to reproduce the behavior: 1. Download a build with DIC version 20210102 on Windows 10 2. Extract MPF 3. Completely ignore the Windows notification (like all other useless notifications) 4. Press "Start Dumping" 5. Try multiple versions of MPF and wonder for a really long time why it won't do anything 6. Hate Windows **Expected behavior** An error message (in the logs) that the program executable is not where it should be. **Screenshots** None **Additional context** None edit: Happy issue 256!
claunia added the bug label 2026-01-29 16:13:15 +00:00
claunia commented 2026-01-29 16:13:16 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Jan 25, 2021):

So this just recently came up from another user as well that DIC's latest version is getting erroneously flagged. The dev of DIC has already been notified, but yeah, that's probably a good idea to check.

@mnadareski commented on GitHub (Jan 25, 2021): So this just recently came up from another user as well that DIC's latest version is getting erroneously flagged. The dev of DIC has already been notified, but yeah, that's probably a good idea to check.
claunia commented 2026-01-29 16:13:17 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Jan 25, 2021):

Possibly addressed as of 999c4dceb5

@mnadareski commented on GitHub (Jan 25, 2021): Possibly addressed as of https://github.com/SabreTools/MPF/commit/999c4dceb59c6daf69b094c3e0dee8bce8c65bf6
claunia commented 2026-01-29 16:13:18 +00:00
Author
Owner
Copy Link

@Nithanim commented on GitHub (Jan 25, 2021):

There is at least an error message now but a bit less informational than I hoped.
image

@Nithanim commented on GitHub (Jan 25, 2021): There is at least an error message now but a bit less informational than I hoped. ![image](https://user-images.githubusercontent.com/2402064/105761815-dd9e5e80-5f53-11eb-8067-a9b5f00e512f.png)
claunia commented 2026-01-29 16:13:18 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Jan 25, 2021):

What would you consider to be more informational? I picked wording that I felt captured the basics.

@mnadareski commented on GitHub (Jan 25, 2021): What would you consider to be more informational? I picked wording that I felt captured the basics.
claunia commented 2026-01-29 16:13:18 +00:00
Author
Owner
Copy Link

@Nithanim commented on GitHub (Jan 25, 2021):

Sorry! I mean it is good that there is a error message now but i would not know what "the program" is. A relative path would have helped me tremendously to discover what was missing and then find out why.

@Nithanim commented on GitHub (Jan 25, 2021): Sorry! I mean it is good that there is a error message now but i would not know what "the program" is. A relative path would have helped me tremendously to discover what was missing and then find out why.
claunia commented 2026-01-29 16:13:19 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Jan 25, 2021):

Ah I see what you mean. I can add that info. One minute.

@mnadareski commented on GitHub (Jan 25, 2021): Ah I see what you mean. I can add that info. One minute.
claunia commented 2026-01-29 16:13:19 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Jan 25, 2021):

Seems like I missed a bit of a check that I had already accounted for long before. I'll clean up what I had.

@mnadareski commented on GitHub (Jan 25, 2021): Seems like I missed a bit of a check that I had already accounted for long before. I'll clean up what I had.
claunia commented 2026-01-29 16:13:19 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Jan 25, 2021):

Try out the changes in 101193cb78

@mnadareski commented on GitHub (Jan 25, 2021): Try out the changes in https://github.com/SabreTools/MPF/commit/101193cb78603fb8f7b7cb302cb460fb84b9e05d
claunia commented 2026-01-29 16:13:19 +00:00
Author
Owner
Copy Link

@Nithanim commented on GitHub (Jan 25, 2021):

Thank you very much! Looks great now.

Populating systems, 116 systems found.
Scanning for drives..
Found 1 drives: D
Trying to detect system for drive D.. unable to detect.
Trying to detect media type for drive D.. detected DVD-ROM.
Supported media speeds: 1, 2, 3, 4, 6, 8, 12, 16, 20, 24
Setting drive speed to: 24
Changed system to: IBM PC Compatible
Starting dumping process..
Error! Programs\Creator\DiscImageCreator.exe does not exist!
@Nithanim commented on GitHub (Jan 25, 2021): Thank you very much! Looks great now. ``` Populating systems, 116 systems found. Scanning for drives.. Found 1 drives: D Trying to detect system for drive D.. unable to detect. Trying to detect media type for drive D.. detected DVD-ROM. Supported media speeds: 1, 2, 3, 4, 6, 8, 12, 16, 20, 24 Setting drive speed to: 24 Changed system to: IBM PC Compatible Starting dumping process.. Error! Programs\Creator\DiscImageCreator.exe does not exist! ```
claunia commented 2026-01-29 16:13:20 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Jan 25, 2021):

Okay, cool. Glad that worked out a bit better.

@mnadareski commented on GitHub (Jan 25, 2021): Okay, cool. Glad that worked out a bit better.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#267
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?